getSimplePanel never called in LayoutUI plugin

Bug #880601 reported by chunky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gephi
Confirmed
Low
chunky

Bug Description

I'm working on a Layout plugin, here: http://icculus.org/~chunky/stuff/gephi_graphviz/

If you download the code, you'll see I have a class "GraphvizUIPanel", one of which is instantiated when Graphviz.GraphvizLayoutUI.getSimplePanel() is called.

According to the javadoc for LayoutUI, if getSimplePanel returns something other than null, then that will be used in place of the simple properties dialog. [several of the options I have in my layout plugin are best expressed as combo boxes containing strings, something that properties aren't conducive to, hence I really would like this feature]

Revision history for this message
chunky (chunky) wrote :

Here's a simple patch that implements the feature.

I edited LayoutPanel in the DesktopLayout module, and added another panel called "layoutProvidedPanel", exactly the same as the propertySheet.

Then:
1) If a panel is provided by the plugin from getSimplePanel, then it is put into the new layoutProvidedPanel. layoutPrivdedPanel is shown, and propertySheet is hidden.
2) If a panel isn't provided, then layoutProvidedPanel is cleared and hidden, and propertySheet is shown.

A plugin that manifests this ability is [some might say "suspiciously"] already working for this:
http://icculus.org/~chunky/stuff/gephi_graphviz/

Revision history for this message
chunky (chunky) wrote :

Oops. Minor sniglets. This one's better.

Revision history for this message
Mathieu Bastian (mathieu.bastian) wrote :

That's awesome thank you! This method was not implemented indeed, probably because of a lack of time. Your approach seems great I'll review it and merge it to the trunk asap.

Revision history for this message
Mathieu Bastian (mathieu.bastian) wrote :

Patch applied in revision 2507. Thank you. We will deploy this patch soon to the Update Center so users will be asked to update their Gephi.

Changed in gephi:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → chunky (chunky)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.