SyncDaemonTool fires returned deferred even if the operation did not completed
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Client |
Fix Released
|
Medium
|
Natalia Bidart | ||
Bug Description
Currently, for some operations like create_folder, SyncDaemonTool fires the returned deferred even if the requested UDF was not fully created. If you see the current code:
def create_folder(self, path):
"""Create a user defined folder in the specified path."""
d = self.wait_
return d
The method only waits for FolderCreated to happen, but it does not filter by path (so a different FolderCreated can be emitted for another folder and then the call will return before completed).
Related branches
- Alejandro J. Cura (community): Approve
- Diego Sarmentero (community): Approve
- Manuel de la Peña (community): Approve
-
Diff: 23495 lines (+6839/-12918)40 files modifiedbin/u1sdtool (+21/-17)
bin/ubuntuone-syncdaemon (+7/-13)
contrib/testing/testcase.py (+146/-10)
tests/platform/__init__.py (+13/-22)
tests/platform/linux/__init__.py (+0/-19)
tests/platform/linux/eventlog/test_zg_listener.py (+5/-2)
tests/platform/linux/test_config.py (+0/-86)
tests/platform/linux/test_dbus.py (+219/-3894)
tests/platform/linux/test_vm.py (+31/-29)
tests/platform/test_external_interface.py (+620/-0)
tests/platform/test_filesystem_notifications.py (+8/-6)
tests/platform/test_tools.py (+395/-249)
tests/platform/test_u1sdtool.py (+63/-46)
tests/platform/windows/__init__.py (+15/-18)
tests/platform/windows/test_ipc.py (+233/-2984)
tests/platform/windows/test_tools.py (+13/-1122)
tests/status/test_aggregator.py (+1/-1)
tests/syncdaemon/test_action_queue.py (+12/-16)
tests/syncdaemon/test_fsm.py (+29/-27)
tests/syncdaemon/test_interaction_interfaces.py (+2262/-467)
tests/syncdaemon/test_localrescan.py (+23/-19)
tests/syncdaemon/test_main.py (+16/-22)
tests/syncdaemon/test_vm.py (+51/-43)
ubuntuone/logger.py (+0/-2)
ubuntuone/platform/__init__.py (+1/-0)
ubuntuone/platform/linux/__init__.py (+10/-58)
ubuntuone/platform/linux/dbus_interface.py (+247/-789)
ubuntuone/platform/tools/__init__.py (+835/-0)
ubuntuone/platform/tools/linux.py (+94/-1008)
ubuntuone/platform/tools/windows.py (+94/-510)
ubuntuone/platform/windows/__init__.py (+11/-44)
ubuntuone/platform/windows/ipc.py (+510/-690)
ubuntuone/platform/windows/ipc_client.py (+80/-96)
ubuntuone/status/aggregator.py (+2/-3)
ubuntuone/syncdaemon/action_queue.py (+6/-4)
ubuntuone/syncdaemon/config.py (+7/-8)
ubuntuone/syncdaemon/interaction_interfaces.py (+727/-566)
ubuntuone/syncdaemon/local_rescan.py (+13/-8)
ubuntuone/syncdaemon/main.py (+8/-9)
ubuntuone/syncdaemon/volume_manager.py (+11/-11)
| Changed in ubuntuone-client: | |
| assignee: | nobody → Natalia Bidart (nataliabidart) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| Changed in ubuntuone-client: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-client: | |
| status: | Fix Committed → Fix Released |
