The daily builds are occasionally getting a spurious test failure:
======================================================================
ERROR: bzrlib.tests.per_interrepository.test_fetch.TestInterRepository.test_fetch_parent_inventories_at_stacking_boundary_smart_old(InterDifferingSerializer+get_known_graph_ancestry,RepositoryFormatKnitPack1,RepositoryFormatKnitPack6RichRoot)
----------------------------------------------------------------------
_StringException: log: {{{
326.165 creating repository in bzr://127.0.0.1:53297/extra/branch/.bzr/.
326.193 creating branch <bzrlib.branch.BzrBranchFormat6 object at 0x8524f4c> in chroot-148171468:///branch/
326.219 preparing to commit
326.238 Selecting files for commit with filter None
326.302 preparing to commit
326.316 Selecting files for commit with filter None
326.410 preparing to commit
326.419 Selecting files for commit with filter None
326.519 preparing to commit
326.519 commit parent revision {right}
326.532 Selecting files for commit with filter None
326.621 creating repository in bzr://127.0.0.1:53297/extra/trunk/.bzr/.
326.647 creating branch <bzrlib.branch.BzrBranchFormat7 object at 0x852742c> in chroot-148171468:///trunk/
326.657 Using fetch logic to copy between RemoteRepository(bzr://127.0.0.1:53297/extra/branch/.bzr/)(RemoteRepositoryFormat(_network_name='Bazaar pack repository format 1 (needs bzr 0.92)\n')) and RemoteRepository(bzr://127.0.0.1:53297/extra/trunk/.bzr/)(RemoteRepositoryFormat(_network_name='Bazaar RepositoryFormatKnitPack6RichRoot (bzr 1.9)\n'))
326.665 fetching: <SearchResult search:(set(['left']), set(['null:']), 2)>
326.667 Traceback (most recent call last):
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/protocol.py", line 907, in accept_bytes
_StatefulDecoder.accept_bytes(self, bytes)
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/protocol.py", line 402, in accept_bytes
self.state_accept()
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/protocol.py", line 1013, in _state_accept_expecting_message_part
self.done()
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/protocol.py", line 1051, in done
raise errors.SmartMessageHandlerError(sys.exc_info())
SmartMessageHandlerError: The message handler raised an exception:
Traceback (most recent call last):
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/protocol.py", line 1049, in done
self.message_handler.end_received()
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/message.py", line 164, in end_received
"Complete conventional request was received, but request "
SmartProtocolError: Generic bzr smart protocol error: Complete conventional request was received, but request handler has not finished reading.
}}}
traceback-5: {{{
Traceback (most recent call last):
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/tests/per_interrepository/test_fetch.py", line 182, in test_fetch_parent_inventories_at_stacking_boundary_smart_old
self.test_fetch_parent_inventories_at_stacking_boundary()
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/tests/per_interrepository/test_fetch.py", line 213, in test_fetch_parent_inventories_at_stacking_boundary
trunk.repository.fetch(branch.repository, 'left')
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/remote.py", line 1673, in fetch
find_ghosts=find_ghosts, fetch_spec=fetch_spec)
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/decorators.py", line 217, in write_locked
result = unbound(self, *args, **kwargs)
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/vf_repository.py", line 2517, in fetch
find_ghosts=find_ghosts)
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/fetch.py", line 76, in __init__
self.__fetch()
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/fetch.py", line 103, in __fetch
self._fetch_everything_for_search(search_result)
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/fetch.py", line 131, in _fetch_everything_for_search
stream, from_format, [])
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/remote.py", line 2098, in insert_stream
(verb, path, '') + lock_args, byte_stream)
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/client.py", line 181, in call_with_body_stream
expect_response_body=False)
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/client.py", line 81, in _call_and_read_response
expect_body=expect_response_body),
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/message.py", line 299, in read_response_tuple
self._wait_for_response_args()
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/message.py", line 264, in _wait_for_response_args
self._read_more()
File "/build/buildd/bzr-2.5.0~bzr6213~ppa3977~oneiric1/build/lib.linux-i686-2.7/bzrlib/smart/message.py", line 286, in _read_more
"Unexpected end of message. "
ConnectionReset: Connection closed: Unexpected end of message. Please check connectivity and permissions, and report a bug if problems persist.
}}}
----------------------------------------------------------------------
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/14/2011 2:32 PM, Jelmer Vernooij wrote:
> Public bug reported:
>
> The daily builds are occasionally getting a spurious test failure:
>
This had been happening on Babune, which caused me to introduce this
change:
6197 Patch Queue Manager 2011-10-06 [merge]
(jameinel) Allow for some tests to run slowly under load. (John
A Meinel)
=== modified file 'bzrlib/
--- bzrlib/
+++ bzrlib/
@@ -616,7 +616,7 @@
-
+
class TestingSmartSer
server.
So if they are still failing, that would indicate the single test is
taking more than 1 minute to complete.
Note that if this really is the failure, the connection retry code
that I wrote should also handle this by just retrying from the client
side.
Though in that traceback there isn't a ConnectionTimeout. Instead it
looks like one side just closes the connection.
Specifically, it looks like the client sends some data, and indicates
that the message is done. The server reads this information, but feels
there is more that needs to be said, and raises an exception, closing
the connection to the client.
Now, if the client is genuinely sending a malformed message, that is
how it is supposed to work.
If find it odd that the test highlighted here is also the one that was
failing because of timeouts, though.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk6
oCUAoKgRrbywsXv
=062Z
-----END PGP SIGNATURE-----