pcmcia-pcix/detect is not a detect test

Bug #866079 reported by Ara Pulido
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Medium
Jeff Lane 

Bug Description

The "detect" tests in checkbox should be only those that fail if the hardware is not present.

If we cannot determine correctly the PCMCIA hardware we should split this test in two:

* One detect to ask the user if their system contains or not PCMCIA
* Another one to actually run the test (depending on detect)

Related branches

Revision history for this message
Daniel Manrique (roadmr) wrote :

Pending some investigation on whether PCMCIA and ExpressCard host controllers can be automatically detected, Ara's proposal sounds reasonable, although we'll again have the "absence of hardware means test failure" problem. It'd definitely be better to handle this through a requires: and some sort of device but I don't see anything in udev_resource we could use for this.

I'll mark this triaged and medium since we can start work on this now :)

Changed in checkbox:
status: New → Triaged
importance: Undecided → Medium
tags: added: checkbox-testsuite
Revision history for this message
Jeff Lane  (bladernr) wrote :

I'm going to say it's not really possible to detect them. There's no "PCMCIA" controller. There may have been at one time, but not anymore. PC Card has been supplanted by ExpressCard. Both PC Card and ExpressCard use either PCIe or USB buses. The slot on your system has to have BOTH a PCIe and USB channel to meet the standard.

Whether a device uses the PCIe or USB channel is arbitrarily decided by whomever makes the device, thus you could, technically, have a USB3 ExpressCard module that uses the PCIe channel and a FireWire ExpressCard module that uses the USB channel.

As for the original proposal of splitting it out, I don't think that's really do-able either. It gets into testing specific modules simply for convenience sake. We may write the test to only test ExpressCard modules that provide USB3.0 ports, but can't expect anyone else to purchase the same USB3.0 ports.

I think the test we have now is pretty adequate, but needs some tweaking.

Changed in checkbox:
assignee: nobody → Jeff Lane (bladernr)
status: Triaged → In Progress
Marc Tardif (cr3)
Changed in checkbox:
status: In Progress → Fix Committed
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.