Graphite

Y-axis intervals are incorrect

Bug #856745 reported by Kyle Kingsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Graphite
Fix Released
High
Nicholas Leskiw

Bug Description

This screenshot shows a graph which has y-axis labels (evenly spaced) of 1,3,4,6,7,9,10; looks like it has to do with the axis scale calculation, because the plotted value doesn't line up with the scale. Maybe a rounding bug? See the rawData attached.

Revision history for this message
Kyle Kingsbury (aphyr) wrote :
Revision history for this message
Kyle Kingsbury (aphyr) wrote :
Revision history for this message
Nicholas Leskiw (nleskiw) wrote :

Please re-render the graph with &yUnitSystem=none. I think that the labels are being rounded. I'll look into keeping two additional decimal places on the y-axis labels when using SI / Binary units to avoid confusion.

Revision history for this message
Kyle Kingsbury (aphyr) wrote :

That does fix it. Units are now 0, 1500000, 3000000, 4500000, etc. :)

Revision history for this message
Nicholas Leskiw (nleskiw) wrote :

Well I think that only triaged it ; )
I'm pushing a fix to trunk to check if the yValue returned from graphite.render.glyph.format_units() is a float.
If it is, (and a few other things are true) it won't convert it to an int.
Also, added a check that yUnitSystem is in UnitSystem.keys(). If not, make it si. (fixes capitalization, too).

Revision history for this message
Kyle Kingsbury (aphyr) wrote :

Wonderful, thanks Nicholas. Graphite is a great piece of software, keep up the good work. :)

Revision history for this message
Nicholas Leskiw (nleskiw) wrote :

Fix committed to trunk, rev574.

Changed in graphite:
importance: Undecided → High
status: New → Confirmed
assignee: nobody → Nicholas Leskiw (nleskiw)
status: Confirmed → Fix Committed
Revision history for this message
Michael Leinartas (mleinartas) wrote :

Released in 0.9.9

Changed in graphite:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.