ztm.commit may break gina's dry-run mode
Bug #848954 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Jeroen T. Vermeulen | ||
Bug Description
After domination, gina does a ztm.commit(). But that does not respect the dry-run option. Either make it conditional, or re-use importer_
(We're not actually sure that dry-run mode works, or who might use it.)
Related branches
lp:~jtv/launchpad/bug-848954
- Graham Binns (community): Approve (code)
-
Diff: 174 lines (+23/-33)3 files modifiedlib/lp/soyuz/scripts/gina/handlers.py (+4/-7)
lib/lp/soyuz/scripts/gina/katie.py (+16/-17)
scripts/gina.py (+3/-9)
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| William Grant (wgrant) wrote | #2 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r13951 <http://