Verification code should be a required field

Bug #848490 reported by Leo Arias
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Windows Installer
Fix Released
Medium
Diego Sarmentero

Bug Description

It is possible not to enter the verification code and click the next button on the wizard.
This try will fail, of course. So, it would be better to disable the Next button if the verification code is empty, to avoid an useless connection.

Related branches

Changed in ubuntuone-windows-installer:
assignee: nobody → Diego Sarmentero (diegosarmentero)
tags: added: u1-zomg-windows
Changed in ubuntuone-windows-installer:
importance: Undecided → Medium
status: New → Triaged
Changed in ubuntuone-windows-installer:
status: Triaged → In Progress
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

I've tried this again, and I got this trace:

2011-09-16 10:29:53,561:561.000108719 - ubuntu_sso.main.windows - INFO - Emittin
g remote signal for on_email_validation_error with callback <bound method EmailV
erificationController.on_email_validation_error of <ubuntu_sso.qt.controllers.Em
ailVerificationController object at 0x031501F0>>.
Peer will receive following PB traceback:
Unhandled Error
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\spread\banana.py", line 153, in go
tItem
    self.callExpressionReceived(item)
  File "C:\Python27\lib\site-packages\twisted\spread\banana.py", line 116, in ca
llExpressionReceived
    self.expressionReceived(obj)
  File "C:\Python27\lib\site-packages\twisted\spread\pb.py", line 515, in expres
sionReceived
    method(*sexp[1:])
  File "C:\Python27\lib\site-packages\twisted\spread\pb.py", line 827, in proto_
message
    self._recvMessage(self.localObjectForID, requestID, objectID, message, answe
rRequired, netArgs, netKw)
--- <exception caught here> ---
  File "C:\Python27\lib\site-packages\twisted\spread\pb.py", line 841, in _recvM
essage
    netResult = object.remoteMessageReceived(self, message, netArgs, netKw)
  File "C:\Python27\lib\site-packages\twisted\spread\flavors.py", line 114, in r
emoteMessageReceived
    state = method(*args, **kw)
  File "E:\ussoc\better-setup-account-button\ubuntu_sso\main\windows.py", line 6
46, in callback_wrapper
    return callback(*args, **kwargs)
  File "E:\ussoc\better-setup-account-button\ubuntu_sso\qt\controllers.py", line
 588, in on_email_validation_error
    self.view.set_error_message(self.view.ui.email_assistance, msg)
exceptions.AttributeError: 'EmailVerificationPage' object has no attribute 'set_
error_message'

Changed in ubuntuone-windows-installer:
status: In Progress → Fix Committed
tags: added: u1-windows
Revision history for this message
Leo Arias (elopio) wrote :

Awesome, I love it when you fix this small deatils :)
Thanks.

Changed in ubuntuone-windows-installer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.