Verification code should be a required field
Bug #848490 reported by
Leo Arias
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Windows Installer |
Fix Released
|
Medium
|
Diego Sarmentero |
Bug Description
It is possible not to enter the verification code and click the next button on the wizard.
This try will fail, of course. So, it would be better to disable the Next button if the verification code is empty, to avoid an useless connection.
Related branches
lp:~diegosarmentero/ubuntu-sso-client/verification-code
- Roberto Alsina (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 138 lines (+59/-7)3 files modifiedubuntu_sso/qt/controllers.py (+20/-5)
ubuntu_sso/qt/tests/__init__.py (+4/-0)
ubuntu_sso/qt/tests/test_controllers.py (+35/-2)
Changed in ubuntuone-windows-installer: | |
assignee: | nobody → Diego Sarmentero (diegosarmentero) |
tags: | added: u1-zomg-windows |
Changed in ubuntuone-windows-installer: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in ubuntuone-windows-installer: | |
status: | Triaged → In Progress |
Changed in ubuntuone-windows-installer: | |
status: | In Progress → Fix Committed |
tags: | added: u1-windows |
To post a comment you must log in.
I've tried this again, and I got this trace:
2011-09-16 10:29:53, 561:561. 000108719 - ubuntu_ sso.main. windows - INFO - Emittin validation_ error with callback <bound method EmailV roller. on_email_ validation_ error of <ubuntu_ sso.qt. controllers. Em Controller object at 0x031501F0>>. lib\site- packages\ twisted\ spread\ banana. py", line 153, in go callExpressionR eceived( item) lib\site- packages\ twisted\ spread\ banana. py", line 116, in ca eived expressionRecei ved(obj) lib\site- packages\ twisted\ spread\ pb.py", line 515, in expres *sexp[1: ]) lib\site- packages\ twisted\ spread\ pb.py", line 827, in proto_ _recvMessage( self.localObjec tForID, requestID, objectID, message, answe lib\site- packages\ twisted\ spread\ pb.py", line 841, in _recvM remoteMessageRe ceived( self, message, netArgs, netKw) lib\site- packages\ twisted\ spread\ flavors. py", line 114, in r eived better- setup-account- button\ ubuntu_ sso\main\ windows. py", line 6 better- setup-account- button\ ubuntu_ sso\qt\ controllers. py", line validation_ error view.set_ error_message( self.view. ui.email_ assistance, msg) AttributeError: 'EmailVerificat ionPage' object has no attribute 'set_
g remote signal for on_email_
erificationCont
ailVerification
Peer will receive following PB traceback:
Unhandled Error
Traceback (most recent call last):
File "C:\Python27\
tItem
self.
File "C:\Python27\
llExpressionRec
self.
File "C:\Python27\
sionReceived
method(
File "C:\Python27\
message
self.
rRequired, netArgs, netKw)
--- <exception caught here> ---
File "C:\Python27\
essage
netResult = object.
File "C:\Python27\
emoteMessageRec
state = method(*args, **kw)
File "E:\ussoc\
46, in callback_wrapper
return callback(*args, **kwargs)
File "E:\ussoc\
588, in on_email_
self.
exceptions.
error_message'