[FFe, UIFe] Dash - When the Dash is open and there is a maximised app in the background, the top bar background should not disappear
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
High
|
Jay Taoko | ||
unity (Ubuntu) |
Fix Released
|
High
|
Jay Taoko |
Bug Description
When the Dash is open and there is a maximised app in the background, the top bar background should not disappear.
To reproduce:
1. Open any window and make it maximised.
2. Open the Dash
What you currently see that is incorrect:
- The background of the top bar disappears showing the background wallpaper in the position where the top bar was.
What you should see:
- The background of the top bar (just the dark bar without any emblems or app title, effectively just the top bar texture) should remain in place, and you should *NOT* be able to see the background wallpaper. For clarity, this change does not change the dash in any way, we are only changing the background *behind* the dash.
Desired solution:
- *ONLY* in the case where there is a maximised window, the top bar background should be displayed when the Dash is open.
- When there is no maximised window the top bar background should not be displayed (as currently happens)
- The attached images "ambiance_
Related branches
- Gord Allott (community): Approve
- Brandon Schaefer (community): Approve
- Jason Smith (community): Approve
-
Diff: 514 lines (+237/-74)10 files modifiedplugins/unityshell/src/BackgroundEffectHelper.cpp (+86/-0)
plugins/unityshell/src/BackgroundEffectHelper.h (+2/-0)
plugins/unityshell/src/Launcher.cpp (+41/-35)
plugins/unityshell/src/OverlayRenderer.cpp (+28/-26)
plugins/unityshell/src/PanelView.cpp (+12/-4)
plugins/unityshell/src/PlacesGroup.cpp (+0/-2)
plugins/unityshell/src/ResultViewGrid.cpp (+0/-2)
plugins/unityshell/src/ScreenEffectFramebufferObject.cpp (+0/-3)
plugins/unityshell/src/unityshell.cpp (+62/-2)
plugins/unityshell/src/unityshell.h (+6/-0)
description: | updated |
description: | updated |
tags: | added: onew udo |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Critical |
status: | New → Fix Committed |
Changed in unity: | |
assignee: | nobody → Gord Allott (gordallott) |
importance: | Undecided → Medium |
milestone: | none → 4.18.0 |
status: | New → Confirmed |
status: | Confirmed → Triaged |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → Triaged |
assignee: | nobody → Gord Allott (gordallott) |
Changed in unity: | |
assignee: | Gord Allott (gordallott) → Mirco Müller (macslow) |
Changed in unity (Ubuntu): | |
assignee: | Gord Allott (gordallott) → Mirco Müller (macslow) |
Changed in unity: | |
milestone: | 4.18.0 → 4.20.0 |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
milestone: | 4.20.0 → 4.22.0 |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | 4.22.0 → 4.24.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
description: | updated |
tags: | added: udp |
Changed in ayatana-design: | |
status: | Fix Released → Fix Committed |
Changed in unity: | |
assignee: | Mirco Müller (macslow) → Brandon Schaefer (brandontschaefer) |
Changed in unity (Ubuntu): | |
assignee: | Mirco Müller (macslow) → Brandon Schaefer (brandontschaefer) |
tags: | added: unity3p |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
importance: | Medium → High |
no longer affects: | unity (Ubuntu Oneiric) |
Changed in unity (Ubuntu): | |
importance: | Medium → High |
tags: | added: top5p |
Changed in ayatana-design: | |
importance: | Critical → High |
importance: | High → Critical |
Changed in unity: | |
milestone: | backlog → 5.8.0 |
Changed in unity: | |
milestone: | 5.8.0 → 5.10.0 |
summary: |
- Dash - When the Dash is open and there is a maximised app in the + [FFe] Dash - When the Dash is open and there is a maximised app in the background, the top bar background should not disappear |
summary: |
- [FFe] Dash - When the Dash is open and there is a maximised app in the - background, the top bar background should not disappear + [FFe, UIFe] Dash - When the Dash is open and there is a maximised app in + the background, the top bar background should not disappear |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
status: | Fix Released → Fix Committed |
tags: |
added: reviewedbydesignp removed: udo udp |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
I think it might be better to get this in before final comes out, as SRU policy might not approve and also the change looks really simple to get in even at this stage(TM)