Launchpad itself

Unclear why series initialization failed

Bug #835024 reported by Diogo Matsubara
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella

Bug Description

When a series initialization fails, the UI says so and provides a link to re-attempt the initialization.

The ui should also say why it failed so users can fix any problem on their side before re-attempting the initialization and wasting resources on something that might fail again for the same reason.

Attached is a screenshot of the series page when it fails.

Related branches

lp:~allenap/launchpad/series-init-failure-explanations-bug-835024
Brad Crittenden (community): Approve (code)
Diff: 132 lines (+44/-7)
3 files modified
database/schema/security.cfg (+1/-1)
lib/lp/soyuz/model/initializedistroseriesjob.py (+22/-1)
lib/lp/soyuz/tests/test_initializedistroseriesjob.py (+21/-5)
lp:~allenap/launchpad/storm-json-property
Gavin Panella (community): Approve
Diff: 12 lines (+1/-1)
1 file modified
versions.cfg (+1/-1)
lp:~allenap/launchpad/series-init-failure-explanations-bug-835024-ui
Benji York (community): Approve (code)
Diff: 0 lines
lp:~allenap/launchpad/series-init-failure-explanations-bug-835024-db
Graham Binns (community): Approve (code)
Diff: 208 lines (+17/-39)
6 files modified
lib/lp/services/memcache/restful.py (+2/-4)
lib/lp/soyuz/model/distributionjob.py (+3/-13)
lib/lp/soyuz/model/distroseriesdifferencejob.py (+5/-5)
lib/lp/soyuz/model/initializedistroseriesjob.py (+1/-3)
lib/lp/soyuz/model/packagecopyjob.py (+5/-13)
versions.cfg (+1/-1)
Revision history for this message
Diogo Matsubara (matsubara) wrote :
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Gavin was looking at this in the past, assigning to him because I can't remember where he got to with it.

Changed in launchpad:
assignee: nobody → Gavin Panella (allenap)
Revision history for this message
Gavin Panella (allenap) wrote :

I think I discussed this a lot at the time, especially with jtv. We
decided to *not* show any detail of the failure, because we would only
have a stack trace (and therefore an OOPS report) to show for it. In
other words, a failure is really a bug. We present it nicely in the UI
because distroseries initialization is sufficiently complicated that
we absolutely expect there to be bugs and some of them may be
transient.

However, we could be missing something. What kind of initialization
failures exist that are not really bugs?

Changed in launchpad:
status: Triaged → Incomplete
Revision history for this message
Julian Edwards (julian-edwards) wrote :

There are some genuine failures, the one that springs to mind is if you are copying multiple parents and they have conflicting package files.

However, copying from a single parent should rarely, if ever fail. That is indeed a bug.

We might want to add a "contact the admin" message. I'm unsure as to whether adding an OOPS code is worthwhile though.

Changed in launchpad:
status: Incomplete → Triaged
Gavin Panella (allenap)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13907 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13907>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13936 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13936>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13954 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13954>.

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Gavin Panella (allenap)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.