Unit tests fail on Python 2.6
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Undecided
|
William Wolf | ||
Bug Description
Unit tests now fail when run on Python 2.6.x because of the use of unittest.assertIn, which was added in Python 2.7
OS version: Ubuntu 10.04 (Lucid)
Python version: 2.6.5
nova revision: 1499
(Tested under virtualenv)
=======
ERROR: test_destroy_
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
=======
ERROR: test_get_
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
=======
ERROR: test_get_
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
=======
ERROR: test_get_host_stats (nova.tests.
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
=======
ERROR: test_get_info (nova.tests.
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
=======
ERROR: test_get_
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
=======
ERROR: test_spawn (nova.tests.
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
=======
ERROR: test_update_
-------
Traceback (most recent call last):
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
File "/var/lib/
return f(self, *args, **kwargs)
File "/var/lib/
self.
AttributeError: 'FakeConnection
Related branches
- Trey Morris (community): Disapprove
- Brian Waldon (community): Disapprove
- William Wolf: Pending requested
-
Diff: 59 lines (+20/-2)4 files modifiednova/tests/__init__.py (+12/-0)
run_tests.sh (+1/-1)
tools/install_venv.py (+5/-1)
tools/pip-requires-2.6 (+2/-0)
- Soren Hansen (community): Approve
- Trey Morris (community): Approve
-
Diff: 25 lines (+18/-0)1 file modifiednova/test.py (+18/-0)
| Changed in nova: | |
| assignee: | nobody → William Wolf (throughnothing) |
| Changed in nova: | |
| status: | New → In Progress |
| Chris Behrens (cbehrens) wrote | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → diablo-rbp |
| Changed in nova: | |
| milestone: | diablo-rbp → 2011.3 |
| status: | Fix Committed → Fix Released |
I see the 2 implementations of this fix involve unittest2. I'm going ahead and merge propping this:
https:/
which is a smaller change. I feel a switch to unittest2 should be a separate proposal, if we wish to do that.
I'll let people fight it out for what they want. No offense taken if my merge prop is not chosen. :)