bugs are marked incomplete_with_response if users or scripts change the status / tags immediately after setting the status

Bug 694678 is another example.

Looking at the activity log of the bug reports it appears that I set the bug to Incomplete and then added some tags, within less than 1 minute, to the bug. While I can rewrite my scripts to change the order of operations I should not have to.

Looking at http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/view/head:/lib/lp/bugs/model/bugtask.py#L1750. It seems that date_last_message is used in the comparison. While adding a tag sends an e-mail I'm not certain it should be considered a message.

I think in the short term you should change your script. Longer term yes, we can look at fancy heuristics to make the system more tolerant (this was designed when all changes were from forms with multiple fields, not ajax or apis).

It'll actually be multiple scripts that need to change the one that modifies the bug reports and the report that we will be creating of bugs that are really 'Incomplete with response'. Additionally the reporting one will need to do grab all the messages from the bug report to see if there is a message with a date created greater than the date the bug task was set to incomplete.

This is a general problem, not just limited to Brian's scripts. It impacts everyone who relies on the with/without response feature to filter bugs needing review.

This bug should be High importance.

Its been like this for a long time, so it certainly not a recent regression; if you're just now starting to use the data and have found its problematic then I can understand its importance and relevance to you. Being 'high' would probably get this seen to in ~ 6-12 months. Maybe. If you need it addressed in the very short term, I urge you to either put forward a patch (warning - the corner cases are going to be hairy, and it will need sql triggers changed, and care not to interact with bug heat : this is a fragile part of the system); or to escalate it via the stakeholder process where its relative urgency can be assessed by the other stakeholders.

I strongly suspect that changing a half dozen scripts will be more effective at addressing this in the short term.

Separately, we can probably tweak the datestamp for became-incomplete for bugs that you identify as being confused about this, using this bug as a reference. Would that help?

It isn't just scripts that cause this; more often it's bug triagers who are going through manually setting tags and priorities as they normally do. The bugs then toggle to "has a response" and thus clutter up the "Incomplete with Response" reports.

For scripts, the workaround we use (quite a bit) is to toggle the bug status to New, and then back to Incomplete. However this has a side effect of re-setting the expiration timeout - which isn't a huge deal, but it does degrade the usefulness of the Incomplete feature a bit.

I'll follow your advice on escalation.

Brad, https://code.launchpad.net/~lifeless/launchpad/bug-759467/+merge/58262 is the branch I was mentioning. It's approved but failed the following tests in ec2:
Failing tests
-------------
 lib/lp/bugs/doc/bugtask-status-workflow.txt

Tests with errors
-----------------
 lp.bugs.browser.tests.test_bugtarget_patches_view.TestBugListingPortletStatsView.test_bugs_with_patches_count
 lp.bugs.browser.tests.test_bugtask.TestBugTaskEditViewStatusField.test_status_field_bug_task_in_status_expired
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugImporter.test_privileged_user_canTransitionToStatus_from_fixreleased
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugImporter.test_privileged_user_canTransitionToStatus_from_wontfix
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugImporter.test_privileged_user_can_unset_fix_released_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugImporter.test_privileged_user_can_unset_wont_fix_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorPerson.test_privileged_user_canTransitionToStatus_from_fixreleased
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorPerson.test_privileged_user_canTransitionToStatus_from_wontfix
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorPerson.test_privileged_user_can_unset_fix_released_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorPerson.test_privileged_user_can_unset_wont_fix_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorTeamMember.test_privileged_user_canTransitionToStatus_from_fixreleased
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorTeamMember.test_privileged_user_canTransitionToStatus_from_wontfix
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorTeamMember.test_privileged_user_can_unset_fix_released_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugSupervisorTeamMember.test_privileged_user_can_unset_wont_fix_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugWatchUpdater.test_privileged_user_canTransitionToStatus_from_fixreleased
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugWatchUpdater.test_privileged_user_canTransitionToStatus_from_wontfix
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugWatchUpdater.test_privileged_user_can_unset_fix_released_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionBugWatchUpdater.test_privileged_user_can_unset_wont_fix_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionForReporter.test_reporter_canTransitionToStatus
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionForReporter.test_reporter_can_unset_fix_released_status
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionForUser.test_user_canTransitionToStatus_from_fixreleased
 lp.bugs.model.tests.test_bugtask_status.TestBugTaskStatusTransitionForUser.test_user_canTransitionToStatus_...

Fixed in stable r14174 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14174>.

The fix for this has been released. Some preexisting bugs that were
incorrectly considered incomplete-with-response will still be considered
such. Moving them to another non-incomplete status and back to
incomplete will get them straightened out.