Ubuntu
gnome-settings-daemon package

screen brightness keys toggle from max to min-brightness (no steps between)

Bug #827517 reported by Kamal Mostafa on 2011-08-16

This bug affects 7 people

Affects		Status	Importance	Assigned to	Milestone
	gnome-settings-daemon (Ubuntu)	Fix Released	High	Rodrigo Moya	Ubuntu ubuntu-11.10
Nominated for Oneiric by Kamal Mostafa

Bug Description

For /sys/class/backlight interfaces which offer more than 20 brightness levels (e.g. the forthcoming 'intel_backlight' interface; LP #568611), gnome-settings-daemon miscalculates the step amount, resulting in StepUp always driving the brightness to maximum and StepDown always driving the brightness to minimum (or backlight-off depending on the interface).

Note that most backlight interfaces (which offer less than 20 levels) don't hit the bug so don't exhibit this problem.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: gnome-settings-daemon 3.1.4-0ubuntu3
ProcVersionSignature: Ubuntu 3.0.0-8.11+username~mjgbacklight5-generic 3.0.1
Uname: Linux 3.0.0-8-generic x86_64
Architecture: amd64
Date: Tue Aug 16 09:46:38 2011
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Alpha amd64 (20110803.1)
ProcEnviron:
PATH=(custom, no user)
LANG=en_US.UTF-8
SHELL=/bin/bash
SourcePackage: gnome-settings-daemon
UpgradeStatus: Upgraded to oneiric on 2011-08-15 (0 days ago)

Tags:

Related branches

lp:~kamalmostafa/ubuntu/oneiric/gnome-settings-daemon/bug-827517

Merged into lp:ubuntu/oneiric/gnome-settings-daemon

Ubuntu branches: Pending requested 2011-08-16

lp:~ubuntu-desktop/gnome-settings-daemon/ubuntu

lp:ubuntu/oneiric/gnome-settings-daemon

Revision history for this message

Kamal Mostafa (kamalmostafa) wrote on 2011-08-16:

Dependencies.txt Edit (4.4 KiB, text/plain; charset="utf-8")

Changed in gnome-settings-daemon (Ubuntu):
assignee:	nobody → Kamal Mostafa (kamalmostafa)
importance:	Undecided → Medium
milestone:	none → ubuntu-11.10
status:	New → In Progress
summary:	- brightness keys StepUp/StepDown toggles from fully-on or fully-off + brightness keys toggles from max to min-brightness (no steps between)

Revision history for this message

Kamal Mostafa (kamalmostafa) wrote on 2011-08-16: Re: brightness keys toggles from max to min-brightness (no steps between)

Attached patch fixes the bug, allowing gnome-settings-daemon to properly compute the step value.

Kamal Mostafa (kamalmostafa) on 2011-08-16

summary:

- brightness keys toggles from max to min-brightness (no steps between)
+ screen brightness keys toggle from max to min-brightness (no steps
+ between)

Brian Murray (brian-murray) on 2011-08-16

tags:

added: patch

Revision history for this message

Kamal Mostafa (kamalmostafa) wrote on 2011-08-16:

50_fix_brightness_step.patch Edit (846 bytes, text/plain)

Attached patch fixes the bug, allowing gnome-settings-daemon to properly compute the step value. (updated patch).

Kamal Mostafa (kamalmostafa) on 2011-08-16

Changed in gnome-settings-daemon (Ubuntu):
assignee:	Kamal Mostafa (kamalmostafa) → nobody
status:	In Progress → Triaged

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-08-19:

Thanks for your work

Rodrigo could you review the patch there?

Changed in gnome-settings-daemon (Ubuntu):
assignee:	nobody → Rodrigo Moya (rodrigo-moya)

Revision history for this message

Kamal Mostafa (kamalmostafa) wrote on 2011-08-24:

The "intel_backlight" kernel component has now landed in Oneiric (bug 568611), so this bug in gnome-settings-daemon is the only thing precluding proper brightness-keys controls for a wide range of laptops. Please apply this trivial patch to fix it.

Changed in gnome-settings-daemon (Ubuntu):
importance:	Medium → High

Revision history for this message

Rodrigo Moya (rodrigo-moya) wrote on 2011-09-01:

Patch looks good, and so has been pushed upstream. It's in our package branch now, and will be released with the next upload. Thanks!

Changed in gnome-settings-daemon (Ubuntu):
status:	Triaged → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-09-02:

This bug was fixed in the package gnome-settings-daemon - 3.1.90-0ubuntu2

---------------
gnome-settings-daemon (3.1.90-0ubuntu2) oneiric; urgency=low

  * debian/patches/01_git_fix_brightness_step_amount.patch:
    - Fix BRIGHTESS_STEP_AMOUNT calculation macro (LP: #827517)
  * debian/patches/01_git_do_power_init_in_start.patch:
    - Do power plugin initialization in _start, not _init, to avoid multiple
      crashes (LP: #836014)
-- Rodrigo Moya <email address hidden> Thu, 01 Sep 2011 10:33:58 +0200