publish-ftpmaster script runs publisher too many times
Bug #824553 reported by
Julian Edwards
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen |
Bug Description
When publishing a distroseries "DSN" for the first time, the publish-ftpmaster script does this:
1. notices release pocket has no indexes, and runs publish-distro.py -A -s DSN
2. notices backports pocket has no indexes, and runs publish-distro.py -A -s DSN-backports
3. notices updates pocket has no indexes, and runs publish-distro.py -A -s DSN-updates
....
and so on.
Instead it should invoke publish-distro.py with one "-s" argument for each suite so that publish-distro runs once and does all the work in one go.
The reason for this is because each run also tries to put files in the pool and do domination. This is very wasteful of CPU.
Related branches
lp:~jtv/launchpad/bug-824553
- Robert Collins (community): Approve
-
Diff: 87 lines (+18/-15)2 files modifiedlib/lp/archivepublisher/scripts/publish_ftpmaster.py (+8/-7)
lib/lp/archivepublisher/tests/test_publish_ftpmaster.py (+10/-8)
lp:~jtv/launchpad/post-824553
- Henning Eggers (community): Approve
-
Diff: 18 lines (+0/-8)1 file modifiedlib/lp/archivepublisher/scripts/publish_ftpmaster.py (+0/-8)
Changed in launchpad: | |
status: | New → In Progress |
importance: | Undecided → High |
tags: | added: derivation |
Changed in launchpad: | |
status: | In Progress → Triaged |
Changed in launchpad: | |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
Changed in launchpad: | |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r13727 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 13727>.