Launchpad itself

NotBranchError raised by upgrade_branches.py script

Bug #823485 reported by Diogo Matsubara
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Aaron Bentley

Bug Description

OOPS-2046UBJ1 shows an upgrade branch job failure: NotBranchError: Not a branch: "/+branch-id/40441/".

Tags: oops qa-ok

Related branches

lp:~abentley/launchpad/upgrade-not-branch-error
Brad Crittenden (community): Approve (code)
Diff: 447 lines (+95/-40)
10 files modified
database/schema/security.cfg (+2/-0)
lib/lp/code/browser/branch.py (+2/-3)
lib/lp/code/interfaces/branch.py (+1/-1)
lib/lp/code/model/branch.py (+2/-2)
lib/lp/code/model/branchjob.py (+18/-3)
lib/lp/code/model/tests/test_branch.py (+7/-8)
lib/lp/code/model/tests/test_branchjob.py (+46/-17)
lib/lp/code/scripts/tests/test_upgrade_branches.py (+2/-2)
lib/lp/scripts/tests/test_garbo.py (+5/-3)
lib/lp/testing/__init__.py (+10/-1)
Revision history for this message
Robert Collins (lifeless) wrote :

This is a failure that should be reported to the user and not us - its normal for some of the hosting branches to have no valid branch content - users can do what they want, after all.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Dupe of bug 86402 then?

Revision history for this message
Robert Collins (lifeless) wrote :

No, for a few reasons;
that bug asks for better help and fixing that wouldn't necessarily imply not oopsing.
this one states that we get an OOPS which isn't one we would want to investigate immediately because its not clearly a system fault (perhaps a use for an informational oops + statistical analysis, but thats a EFUTURE project).
They are for different components - this is the job upgrader, that is the branch mirrorer.

Aaron Bentley (abentley)
Changed in launchpad:
assignee: nobody → Aaron Bentley (abentley)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13756 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13756>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

Tested a few cases on qastaging, got https://pastebin.canonical.com/51620/. Can't see any emails, but the success case still works, so this is qa-ok.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.