pt-query-digest shouldn't print "Error: none" for tcpdump
Bug #823411 reported by
Daniel Nichter
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Daniel Nichter | ||
Bug Description
Imported from http://
When pt-query-digest --type tcpdump is used and a query has no errors, an "Error: none" line is printed. This don't conform to other attributes where if there's no value then no value is printed. The "none" value is a hack that we need to fix.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/mysql-connect-errors-bug-1103045
- Daniel Nichter: Approve
-
Diff: 1382 lines (+502/-105)20 files modifiedbin/pt-query-digest (+37/-9)
lib/MySQLProtocolParser.pm (+39/-9)
t/lib/MySQLProtocolParser.t (+108/-63)
t/lib/samples/tcpdump/tcpdump042.txt (+59/-0)
t/lib/samples/tcpdump/tcpdump043.txt (+82/-0)
t/lib/samples/tcpdump/tcpdump044.txt (+70/-0)
t/pt-query-digest/mysql_analyses.t (+26/-2)
t/pt-query-digest/samples/tcpdump001.txt (+0/-1)
t/pt-query-digest/samples/tcpdump002_report.txt (+0/-4)
t/pt-query-digest/samples/tcpdump012.txt (+0/-1)
t/pt-query-digest/samples/tcpdump017_report.txt (+0/-1)
t/pt-query-digest/samples/tcpdump021.txt (+0/-3)
t/pt-query-digest/samples/tcpdump022.txt (+0/-2)
t/pt-query-digest/samples/tcpdump023.txt (+0/-2)
t/pt-query-digest/samples/tcpdump024.txt (+0/-2)
t/pt-query-digest/samples/tcpdump025.txt (+0/-2)
t/pt-query-digest/samples/tcpdump033.txt (+0/-3)
t/pt-query-digest/samples/tcpdump041.txt (+0/-1)
t/pt-query-digest/samples/tcpdump043_report.txt (+41/-0)
t/pt-query-digest/samples/tcpdump044_report.txt (+40/-0)
| Changed in percona-toolkit: | |
| status: | New → Confirmed |
| tags: | added: wrong-output |
| Changed in percona-toolkit: | |
| milestone: | none → 2.1.9 |
| status: | Confirmed → In Progress |
| importance: | Wishlist → High |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #1 |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #2 |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #3 |
To post a comment you must log in.
Being fixed as part of bug 1103045.