Webkit-based reports aren't properly translated

Bug #819334 reported by Lorenzo Battistini
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Low
OpenERP Publisher's Warranty Team

Bug Description

server revno 3468
addons revno 4739

Steps:

 - Install 'report_webkit_sample'
 - Install Italian language
 - Export it.po for 'report_webkit_sample' module by Administration menu

You'll see lines like these

#. module: report_webkit_sample
#: report:addons/report_webkit_sample/report/report_webkit_html.mako:35
msgid "Supplier Invoice"
msgstr "Supplier Invoice"

while they should be as follows

#. module: report_webkit_sample
#: report:report.webkitaccount.invoice:35
msgid "Supplier Invoice"
msgstr "Fattura Fornitore"

Due to the line
#: report:addons/report_webkit_sample/report/report_webkit_html.mako:35
translation couldn't correctly imported.

So, if you make your own custom report, you have to manually edit those lines in order to import terms correctly

Tags: maintenance

Related branches

Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

Hello ,

This bug is only reproducible with current stable not trunk version so I am assigning this to OPW team.

Thanks.

Changed in openobject-server:
assignee: nobody → OpenERP Publisher's Warranty Team (openerp-opw)
importance: Undecided → Low
status: New → Confirmed
tags: added: maintenance
Changed in openobject-server:
status: Confirmed → In Progress
Changed in openobject-server:
status: In Progress → Confirmed
Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

hi, any news about this issue?

Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

btw, this issue is present on current trunk as well

summary: - Bad format of exported report translation
+ Webkit-based reports aren't properly translated
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello Lorenzo,

The fix has landed in trunk at revision [1] and was also backported to 6.0 (for the corresponding OPW case) at revision [2].

See also the commit comment for revision [1] if you are interested in the technical details.

Thanks for reporting!

[1] trunk addons rev.6365 revid: <email address hidden>
[2] 6.0 addons rev.5009 revid: <email address hidden>

Changed in openobject-server:
milestone: none → 6.0.4
status: Confirmed → Fix Released
Revision history for this message
Niels Huylebroeck (red15) wrote :

Calling security alert on this commit, tempfile.mktemp is unsecure and the current way its used will very likely produce strange results in high concurrency enviroments where multiple webkit reports will be running simultaneously !

Revision history for this message
Niels Huylebroeck (red15) wrote :

Sorry, just as I posted I saw prefix,suffix usage so wont have problems in high concurrency usage,

however the security problem with tempfile.mktemp still stands, use either tempfile.mkstemp or the solution explained here : http://docs.python.org/library/tempfile.html#tempfile.mktemp

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.