Handle encoding of the options returned by ConfigGlue
Bug #818197 reported by
Alejandro J. Cura
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Client |
Fix Released
|
Critical
|
Diego Sarmentero | ||
Bug Description
The command line arguments in sys.argv are always of type "str", even in windows, where they are encoded with "mbcs".
We should verify if ConfigGlue also returns "str" when getting the arguments from the command line or from the config files, and convert them to the encoding that syncdaemon expects (utf-8).
This will be needed if the user passes in a parameter to syncdaemon using non-ascii characters, both from the command line or from a config file.
Related branches
lp:~alecu/ubuntuone-client/unicode-usernames
- Manuel de la Peña (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 403 lines (+115/-25)12 files modifiedtests/platform/test_filesystem_notifications.py (+13/-1)
tests/syncdaemon/test_config.py (+24/-1)
tests/syncdaemon/test_vm.py (+35/-0)
ubuntuone/platform/linux/__init__.py (+1/-0)
ubuntuone/platform/linux/os_helper.py (+5/-0)
ubuntuone/platform/windows/__init__.py (+1/-0)
ubuntuone/platform/windows/os_helper.py (+6/-6)
ubuntuone/platform/xdg_base_directory/__init__.py (+4/-1)
ubuntuone/syncdaemon/config.py (+18/-10)
ubuntuone/syncdaemon/filesystem_notifications.py (+2/-2)
ubuntuone/syncdaemon/main.py (+3/-2)
ubuntuone/syncdaemon/volume_manager.py (+3/-2)
| Changed in ubuntuone-client: | |
| importance: | High → Medium |
| summary: |
- Encoding of the options returned by ConfigGlue + Handle encoding of the options returned by ConfigGlue |
| Changed in ubuntuone-client: | |
| status: | Confirmed → Triaged |
| importance: | Medium → Low |
| assignee: | Natalia Bidart (nataliabidart) → Ubuntu One Desktop+ team (ubuntuone-desktop+) |
| Changed in ubuntuone-client: | |
| importance: | Low → Critical |
| assignee: | Ubuntu One Desktop+ team (ubuntuone-desktop+) → Alejandro J. Cura (alecu) |
| Changed in ubuntuone-client: | |
| status: | Triaged → In Progress |
| tags: | added: u1-windows |
| tags: | removed: u1-windows-cleanups |
| Changed in ubuntuone-client: | |
| status: | In Progress → Fix Released |
| Changed in ubuntuone-client: | |
| assignee: | Alejandro J. Cura (alecu) → Diego Sarmentero (diegosarmentero) |
| status: | Fix Released → In Progress |
| Changed in ubuntuone-client: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-client: | |
| milestone: | none → 2.99.0 |
| Changed in ubuntuone-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
