[needs-packaging] indicator-cpufreq

Package now in REVU:
http://revu.ubuntuwire.com/p/indicator-cpufreq

Marking incomplete due to comments on REVU, I'm also subscribing ubuntu-sponsors for the time being. Please resubscribe when the comments are addressed.

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Issues mentioned on REVU are fixed, resubscribing sponsors.

Thanks for your branch. I had a look at it and the packaging is fine now. Some comments on the code itself:

/usr/bin/indicator-cpufreq-selector
should probably move into a new dir /usr/share/indicator-cpufreq or /usr/lib/indicator-cpufreq as its not useful
to run on its own but instead is auto-started.

Its great to have a manpage :) It would be good if it would explain how to add indicator-cpufreq to the panel
(i.e. if its enough to have it installed, a small note about this would be sufficient). It does not appear on my
box but maybe thats because my system does not support it?

In bin/indicator-cpufreq I see:
"""
python_path = []
if os.path.abspath(__file__).startswith('/opt'):
    syspath = sys.path[:] # copy to avoid infinite loop in pending objects
    for path in syspath:
        opt_path = path.replace('/usr', '/opt/extras.ubuntu.com/indicator_cpufreq')
        python_path.insert(0, opt_path)
        sys.path.insert(0, opt_path)
python_path = []
if os.path.abspath(__file__).startswith('/opt'):
    syspath = sys.path[:] # copy to avoid infinite loop in pending objects
    for path in syspath:
        opt_path = path.replace('/usr', '/opt/extras.ubuntu.com/indicator_cpufreq')
        python_path.insert(0, opt_path)
        sys.path.insert(0, opt_path)
"""
That looks like its accidently duplicated?

Installing the /var/lib/polkit-1/indicator-cpufreq.pkla looks odd to me, could you please explain a bit more
why its needed? It seems like the .policy file takes already care of this as the default for admin is "unix-group:admin"
(just as its in the local policy file).

Otherwise it looks great, thanks a lot for the work on this! My comments on this should probably also be forwarded
to upstream. The only thing I would really like to know more about is the /var/lib/polkit-1/indicator-cpufreq.pkla
the otherwise I think its ready for upload.

Michael, I'm the upstream author, comments acknowledged.

indicator-cpufreq.pkla is a required file for giving noauth CPU frequency control to the local users in "admin" group. This is compatible with the original behaviour of Gnome applet in Ubuntu - allows local admins to toggle frequency/governor without entering the password.

Original Ubuntu behaviour is coded in policykit-desktop-privileges package with the actual privileges being here:
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/oneiric/policykit-desktop-privileges/oneiric/view/head:/com.ubuntu.desktop.pkla

Installation path for *.pkla updated in the latest REVU upload.

Hi and sorry for the delay to give you an answer!

Given that we are past Feature Freeze, you would need a Feature Freeze exception before any upload. Sorry about that.
You can find how to get a FFe at https://wiki.ubuntu.com/FreezeExceptionProcess.

Unsubscribing sponsors for the moment. As soon as you get the approval for the FFe, please subscribe them again.

Thanks,
Fabrice

Resubscribing sponsors, since Precise is open.

Uploaded. I only changed 'oneiric' to 'precise'. Should be sitting in the NEW queue now.