Spud

add_option in python interface returns "SPUD_NEW_KEY_WARNING"

Bug #813431 reported by Jon Hill on 2011-07-20

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Spud	In Progress	Low	Jon Hill

Bug Description

I think this warning is superfluous as the user is aware that they are adding a new key and just causes an error trap in user code which is unnecessary

Related branches

lp:~spud/spud/add_option_fix

Ready for review for merging into lp:spud

Patrick Farrell: Pending requested 2011-09-02

Revision history for this message

Jon Hill (jon-hill) wrote on 2011-07-20:

patch Edit (364 bytes, text/plain)

Patch attached with an extra condition on the return of add_options.

Revision history for this message

Patrick Farrell (pefarrell) wrote on 2011-08-16:

I agree: add_option shouldn't complain that it has added an option. Jon, can you apply your patch on a branch and make a merge request?

Revision history for this message

Jon Hill (jon-hill) wrote on 2011-09-02:

Done. Merge requested.

Revision history for this message

Florian Rathgeber (florian-rathgeber) wrote on 2012-01-25:

This still isn't fixed on the C++ layer (fix is trivial). We should reject Jon's merge request (since it's only a fix for the Python interface) and send a merge request for a C++ fix. Opinions?

Florian Rathgeber (florian-rathgeber) on 2012-01-25