Launchpad itself

Replace source package files, publishing history and similar bug expanders

Bug #807434 reported by Данило Шеган
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Данило Шеган

Bug Description

Expanders on pages like https://bugs.launchpad.dev/ubuntu/warty/+source/mozilla-firefox, https://launchpad.dev/ubuntu/+source/mozilla-firefox/4.1.2-1ubuntu1/+publishinghistory or similar bugs bug expanders on https://bugs.launchpad.dev/firefox/+filebug (search for "a") should be replaced with our generic Expander implementation from lib/lp/app/javascript/expander.js.

Related branches

lp:~danilo/launchpad/replace-expanders-2
Abel Deuring (community): Approve (code)
Diff: 521 lines (+114/-148)
11 files modified
lib/lp/app/javascript/expander.js (+17/-4)
lib/lp/app/javascript/lp.js (+0/-31)
lib/lp/app/javascript/tests/test_expander.js (+8/-0)
lib/lp/bugs/javascript/filebug_dupefinder.js (+23/-48)
lib/lp/bugs/javascript/tests/test_filebug_dupfinder.js (+3/-4)
lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+1/-7)
lib/lp/soyuz/browser/publishing.py (+0/-17)
lib/lp/soyuz/stories/soyuz/xx-queue-pages.txt (+4/-4)
lib/lp/soyuz/templates/distributionsourcepackage-publishinghistory.pt (+18/-0)
lib/lp/soyuz/templates/distroseries-queue.pt (+35/-27)
lib/lp/soyuz/templates/publishinghistory-macros.pt (+5/-6)
lp:~danilo/launchpad/re-land-13438 (Merged)
lp:~danilo/launchpad/replace-expanders (Merged)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13438 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13438>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

The expanders on DistributionSourcePackage:+index no longer work. There are two arrows, but neither of them show anything.

tags: added: qa-bad
removed: qa-needstesting
tags: added: bad-commit-13438
Revision history for this message
Данило Шеган (danilo) wrote :

I am on it.

Revision history for this message
Данило Шеган (danilo) wrote :

Though, this seems to rather be the problem with bug 806925 landing (replacing expanders on PPA:+packages page, without realizing that the same JS is used on this page as well).

Данило Шеган (danilo)
tags: added: qa-needstesting
removed: bad-commit-13438 qa-bad
Revision history for this message
Данило Шеган (danilo) wrote :

This was rolled-back, re-landing.

Данило Шеган (danilo)
tags: removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13445 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13445>.

tags: added: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

Rolled back in r13453, as the fix in lp:~danilo/launchpad/fix-806925 is not yet landed. Bug #812044 was also found during QA, and a fix for that would be nice. DSP:+publishinghistory's expanders have also lost their link cursor.

tags: added: qa-untestable
removed: qa-needstesting
Revision history for this message
Данило Шеган (danilo) wrote :

I'll fix the cursor issue, and look into bug 812044 separately. The fix-806925 didn't land because of a single test failure looking for the IMG tag. :/ Re-landing this and bug-806925 together now.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13457 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13457>.

tags: added: qa-needstesting
removed: qa-untestable
Данило Шеган (danilo)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.