patch for bug #803270 breaks OS X
Bug #806975 reported by
Alexey Kopytov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Undecided
|
Alexey Kopytov | ||
| 5.1 |
Fix Released
|
Undecided
|
Alexey Kopytov | ||
| 5.5 |
Fix Released
|
Undecided
|
Alexey Kopytov | ||
Bug Description
For some reasons fdatasync() is available but is not declared on OS X. So after the patch for bug #803270 I get the following warning (actually error, since I build with -Werror):
os/os0file.c: In function ‘os_file_fsync’:
os/os0file.c:1967: warning: implicit declaration of function ‘fdatasync’.
The solution is to replace
#ifdef HAVE_FDATASYNC
with
#if defined(
That's what the server has in my_sync.c
| Changed in percona-server: | |
| assignee: | nobody → Alexey Kopytov (akopytov) |
Revision history for this message
| Alexey Kopytov (akopytov) wrote | #1 |
Revision history for this message
| Yasufumi Kinoshita (yasufumi-kinoshita) wrote | #2 |
Revision history for this message
| Alexey Kopytov (akopytov) wrote | #3 |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #4 |
To post a comment you must log in.
Another problem introduced by that patch is that in case HAVE_FDATASYNC is not defined, there is a new warning:
os/os0file.c:1954: warning: unused parameter ‘metadata'