PersonPickers broken from bad passed in config
Bug #806179 reported by
j.c.sackett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
j.c.sackett | ||
Bug Description
A recent branch updated the personpicker to take configuration options to determine which button to show, passed into the javascript from the view via the template.
Unfortunately, the value passed in was a python boolean, (e.g. True or False), when javascript needs 'true' or 'false'
Related branches
lp:~jcsackett/launchpad/button-configs-break-pickers
- Aaron Bentley (community): Approve
-
Diff: 350 lines (+86/-20)11 files modifiedlib/lp/app/browser/lazrjs.py (+5/-1)
lib/lp/app/javascript/lazr/picker/person_picker.js (+12/-4)
lib/lp/app/javascript/picker_patcher.js (+1/-5)
lib/lp/app/javascript/tests/test_personpicker.js (+2/-2)
lib/lp/app/javascript/tests/test_picker.js (+22/-4)
lib/lp/app/widgets/popup.py (+7/-0)
lib/lp/app/widgets/templates/form-picker-macros.pt (+4/-0)
lib/lp/app/widgets/tests/test_popup.py (+21/-1)
lib/lp/bugs/javascript/bugtask_index.js (+1/-0)
lib/lp/code/browser/sourcepackagerecipe.py (+2/-1)
lib/lp/registry/browser/team.py (+9/-2)
Revision history for this message
| j.c.sackett (jcsackett) wrote | #1 |
| Changed in launchpad: | |
| importance: | High → Medium |
| importance: | Medium → Critical |
Revision history for this message
| William Grant (wgrant) wrote | #2 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: person-picker qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Escalating this to critical per Robert's suggestion on IRC.