URL hacking to +initseries for an already-initialized series OOPSes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Raphaël Badin |
Bug Description
Traceback (most recent call last):
Module zope.publisher.
result = publication.
Module canonical.
return mapply(ob, request.
Module zope.publisher.
return debug_call(obj, args)
__traceback_info__: <security proxied zope.browserpag
Module zope.publisher.
return obj(*args)
Module canonical.
self.initialize()
Module lp.registry.
self.context.
Module lp.registry.
'value': series.id,
AttributeError: 'NoneType' object has no attribute 'id'<br />
In this case previous_series is None, which is correct for the first series in a new distro.
We can do one of 2 things:
1. redirect +initseries back to the series page
2. make it work properly and say that the series is already initialized
Related branches
- Aaron Bentley (community): Approve
-
Diff: 146 lines (+72/-2)5 files modifiedlib/lp/registry/browser/distroseries.py (+13/-1)
lib/lp/registry/browser/tests/test_distroseries.py (+24/-0)
lib/lp/registry/templates/distroseries-initialize.pt (+8/-0)
lib/lp/soyuz/scripts/initialize_distroseries.py (+8/-1)
lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py (+19/-0)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
The same error happens when trying to initialize the 2nd series in a distro.