some person pickers show "assign me"/"remove assignee" when that makes no sense
Bug #801388 reported by
Michael Hudson-Doyle
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
For example: http://
Related branches
lp:~wallyworld/launchpad/silly-personpicker-assignme
- j.c.sackett (community): Approve
-
Diff: 286 lines (+59/-16)9 files modifiedlib/lp/app/browser/lazrjs.py (+5/-1)
lib/lp/app/javascript/picker.js (+1/-5)
lib/lp/app/javascript/tests/test_picker.js (+22/-4)
lib/lp/app/javascript/widgets.js (+12/-4)
lib/lp/app/widgets/popup.py (+7/-0)
lib/lp/app/widgets/templates/form-picker-macros.pt (+5/-1)
lib/lp/bugs/javascript/bugtask_index.js (+1/-0)
lib/lp/code/browser/sourcepackagerecipe.py (+2/-1)
lib/lp/registry/browser/team.py (+4/-0)
lp:~jcsackett/launchpad/button-configs-break-pickers
- Aaron Bentley (community): Approve
-
Diff: 350 lines (+86/-20)11 files modifiedlib/lp/app/browser/lazrjs.py (+5/-1)
lib/lp/app/javascript/lazr/picker/person_picker.js (+12/-4)
lib/lp/app/javascript/picker_patcher.js (+1/-5)
lib/lp/app/javascript/tests/test_personpicker.js (+2/-2)
lib/lp/app/javascript/tests/test_picker.js (+22/-4)
lib/lp/app/widgets/popup.py (+7/-0)
lib/lp/app/widgets/templates/form-picker-macros.pt (+4/-0)
lib/lp/app/widgets/tests/test_popup.py (+21/-1)
lib/lp/bugs/javascript/bugtask_index.js (+1/-0)
lib/lp/code/browser/sourcepackagerecipe.py (+2/-1)
lib/lp/registry/browser/team.py (+9/-2)
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: disclosure ui |
| Changed in launchpad: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| status: | Triaged → In Progress |
| tags: | added: person-picker |
Revision history for this message
| Huw Wilkins (huwshimi) wrote | #2 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| j.c.sackett (jcsackett) wrote | #4 |
| tags: |
added: qa-bad removed: qa-ok |
| tags: | added: bad-commit-13334 |
Revision history for this message
| William Grant (wgrant) wrote | #5 |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| assignee: | Ian Booth (wallyworld) → j.c.sackett (jcsackett) |
| tags: | removed: bad-commit-13334 qa-bad |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #6 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm half tempted to mark this a regression.