light-themes don't fully support Gnome Shell

Bug #800315 reported by Eric Appleman
138
This bug affects 29 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Won't Fix
Undecided
Unassigned
Mutter
Unknown
Medium
light-themes
Invalid
Undecided
Unassigned
light-themes (Ubuntu)
Invalid
Undecided
Unassigned
mutter (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: light-themes

I shouldn't have to change my GTK theme, window border theme, etc. every time I switch my desktop environment.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: light-themes 0.1.8.15
ProcVersionSignature: Ubuntu 3.0-1.2-genusername 3.0.0-rc3
Uname: Linux 3.0-1-generic i686
Architecture: i386
Date: Tue Jun 21 13:43:31 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release i386 (20110427.1)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, no user)
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: light-themes
UpgradeStatus: Upgraded to oneiric on 2011-06-01 (19 days ago)

Related branches

Revision history for this message
Eric Appleman (erappleman) wrote :
summary: - light-themes needs a GNOME Shell theme so it can coexist with Unity on
- the same machine without switching themes each time
+ light-themes needs a GNOME Shell theme for seamless switching between
+ the Shell and Unity
Revision history for this message
Eric Appleman (erappleman) wrote : Re: light-themes needs a GNOME Shell theme for seamless switching between the Shell and Unity

Unity either needs to support Adwaita better or GNOME Shell needs an Ambiance theme.

Jeremy Bícha (jbicha)
summary: - light-themes needs a GNOME Shell theme for seamless switching between
- the Shell and Unity
+ light-themes don't fully support Gnome Shell
Changed in light-themes (Ubuntu):
status: New → Confirmed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Please see the attached screenshots.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Changing the window theme in Gnome Shell requires logging out and back in to see the change or you should be able to use a shortcut: Enter Alt+F2, then enter r and press enter.

Revision history for this message
Eric Appleman (erappleman) wrote : Re: [Bug 800315] Re: light-themes don't fully support Gnome Shell

On 08/17/2011 06:38 PM, Jeremy Bicha wrote:
> Changing the window theme in Gnome Shell requires logging out and back
> in to see the change or you should be able to use a shortcut: Enter
> Alt+F2, then enter r and press enter.
>
> ** Attachment added: "gnome-shell-ambiance-window-theme.png"
> https://bugs.launchpad.net/light-themes/+bug/800315/+attachment/2287279/+files/gnome-shell-ambiance-window-theme.png
>
gnome-tweak-tools is a remedy for this bug if you don't mind switching
every theme element when you switch desktop environments.

Revision history for this message
Paul Sladen (sladen) wrote :

Jeremy/Eric: patches welcomed if you can debug and figure out what isn't being switched by default, but /is/ being switched when gnome-tweak-tools is used.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

sladen, GNOME Shell doesn't like the shadow and padding lines in metacity-1/metacity-theme-1.xml . If all of those lines are removed, the themes work just fine in GNOME Shell.

Window manager warning: Failed to load theme "Ambiance": Line 497 character 43: Element <padding> is not allowed below <frame_style>

Revision history for this message
Jeremy Bícha (jbicha) wrote :

And I guess if you don't think that should fail you should look at Mutter's src/ui/theme-parser.c

Changed in light-themes:
status: New → Confirmed
John Lea (johnlea)
Changed in ayatana-design:
status: New → Won't Fix
Revision history for this message
Timo Kluck (tkluck) wrote :

I'm marking this as affecting mutter, because it's easy to distro-patch mutter to ignore the shadow and padding arguments. I'm attaching a debdiff.

I'm not familiar with all procedures yet, but I'll try to find a sponsor for this.

Revision history for this message
Andrea Cimitan (cimi) wrote :

I just had a quick look at the patch:
1) why you moved the break from before case STATE_MENU_ICON to after that line? mistake?
2) while I agree we don't want to write g_assert for all shadow and padding lines, I don't like the fact we are skipping also other fallback options. I suggest to not use STATE_FALLBACK but a different (new) state like UBUNTU_STATE_FALLBACK, where we can skip the gasserts

Revision history for this message
Timo Kluck (tkluck) wrote :

Andrea: Thanks for your comments!

1) yes, this was a mistake.
2) the new patch implements what you suggest.

Revision history for this message
Andrea Cimitan (cimi) wrote :

That patch looks fine to me. Someone from Desktop team?

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "ignore-shadow-and-padding.debdiff" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Changed in mutter (Ubuntu):
status: New → In Progress
Revision history for this message
Michael Vogt (mvo) wrote :

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading mutter_3.1.92-0ubuntu3.dsc: done.
  Uploading mutter_3.1.92-0ubuntu3.debian.tar.gz: done.
  Uploading mutter_3.1.92-0ubuntu3_source.changes: done.
Successfully uploaded packages.

Changed in mutter (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mutter - 3.1.92-0ubuntu3

---------------
mutter (3.1.92-0ubuntu3) oneiric; urgency=low

  * debian/patches/04_ignore_shadow_and_padding.patch: Silently ignore
    padding and shadow tags (LP: #800315)
 -- Timo Kluck <email address hidden> Wed, 21 Sep 2011 17:51:28 +0200

Changed in mutter (Ubuntu):
status: Fix Committed → Fix Released
Michael Terry (mterry)
Changed in light-themes (Ubuntu):
status: Confirmed → Invalid
Changed in light-themes:
status: Confirmed → Invalid
Changed in mutter:
importance: Unknown → Medium
status: Unknown → New
Changed in mutter:
status: New → Unknown
Revision history for this message
Eric Appleman (erappleman) wrote :

Unity still doesn't respect window theme or whatever you set in Gnome Tweak Tools.

Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

Isn't that unrelated to this bug report? Report a new one ;-)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.