Incorrect generated logrotate file

Thanks for the bug report, Ill see if I can get this fixed.

Regards
chuck

I've looked a little bit at the .postinst script but I can't see how this could happen, except when there is something wrong in the config file itself. Like 'LogFile 0' in it or something :)

@Javier, do you by any chance have the clamd.conf file ? Or can you reproduce this problem in any consistent way?

Hi there

Javier is a developer on a linux control system / distribution called zentyal. It was myself and another user who spotted this on our installations.

I've attatched my clamd.conf. If you need any further info please ask

Details on the zentyal forum here.
http://forum.zentyal.org/index.php/topic,14558.0.html

This bug appears because of the way we get conf parameters values, for LogFile:

grep '^LogFile' /etc/clamav/clamd.conf
LogFileMaxSize 0
LogFile /var/log/clamav/clamav.log
LogFileUnlock false
LogFileMaxSize 0

The fix:

diff clamav-daemon.postinst /var/lib/dpkg/info/clamav-daemon.postinst
175c175
< value=`grep "^$variable[[:space:]]" $CLAMAVCONF | head -n1 | awk '{print $2}'`
---
> value=`grep ^$variable $CLAMAVCONF | head -n1 | awk '{print $2}'`

Test:
< + grep ^LogFile /etc/clamav/clamd.conf
< + value=0
< + [ -z 0 ]
< + [ 0 != LogFile ]
< + export LogFile=0
---
> + awk {print $2}
> + grep ^LogFile[[:space:]] /etc/clamav/clamd.conf
> + value=/var/log/clamav/clamav.log
> + [ -z /var/log/clamav/clamav.log ]
> + [ /var/log/clamav/clamav.log != LogFile ]
> + export LogFile=/var/log/clamav/clamav.log

Status changed to 'Confirmed' because the bug affects multiple users.

debdiff for Precise

debdiff for saucy

Raring is EOL, and it's probably not worth any more SRUing this to quantal either.

Trusty branch uploaded.

I uploaded the precise branch with the same change that I did to the trusty one:

- value=`grep ^$variable $CLAMAVCONF | head -n1 | awk '{print $2}'`
+ value=`grep "^$variable[[:space:]]" $CLAMAVCONF | head -n1 | awk '{print $2}'`

Unsubscribing sponsors now.

This bug was fixed in the package clamav - 0.98.1+dfsg-1ubuntu5

---------------
clamav (0.98.1+dfsg-1ubuntu5) trusty; urgency=low

  * debian/common_functions
    - Fix slurp_config() that is sometimes not discriminative
    enough which leads to invalid configuration files (LP: #799623)
 -- Louis Bouchard <email address hidden> Mon, 10 Feb 2014 17:56:52 +0100

Hello Javier, or anyone else affected,

Accepted clamav into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/clamav/0.97.8+dfsg-1ubuntu1.12.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Javier, or anyone else affected,

Accepted clamav into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/clamav/0.97.8+dfsg-1ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I've also fixed this in Debian Unstable as well.

@Bryan : thanks I'll do my best to get it tested this week, I was off sick all of last week.

@scott: thanks, I meant to do it but it somewhat dropped of

Verified for both Saucy & Precise. Work as expected.

This bug was fixed in the package clamav - 0.97.8+dfsg-1ubuntu1.12.04.2

---------------
clamav (0.97.8+dfsg-1ubuntu1.12.04.2) precise-proposed; urgency=low

  * debian/common_functions
    - Fix slurp_config() that is sometimes not discriminative
    enough which leads to invalid configuration files (LP: #799623)
 -- Louis Bouchard <email address hidden> Mon, 10 Feb 2014 17:54:42 +0100

The verification of the Stable Release Update for clamav has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

This bug was fixed in the package clamav - 0.97.8+dfsg-1ubuntu4.1

---------------
clamav (0.97.8+dfsg-1ubuntu4.1) saucy; urgency=low

  * debian/common_functions
    - Fix slurp_config() that is sometimes not discriminative
    enough which leads to invalid configuration files (LP: #799623)
 -- Louis Bouchard <email address hidden> Thu, 27 Feb 2014 17:05:17 -0600

This bug was fixed in the package clamav - 0.98.1+dfsg-4ubuntu1~ubuntu12.10.2

---------------
clamav (0.98.1+dfsg-4ubuntu1~ubuntu12.10.2) quantal-security; urgency=medium

  * Rebuild as a security update (LP: #1296856)
 -- Marc Deslauriers <email address hidden> Thu, 27 Mar 2014 08:54:58 -0400