Bug #797387 “[needs-packaging] rdscli” : Bugs : rdscli package : Ubuntu

Revision history for this message

Scott Moser (smoser) wrote on 2011-06-14:

#1

This has been in the awstools ppa for a while (https://launchpad.net/~awstools-dev/+archive/awstools).

It is similar to the ec2-api-tools, iamcli, and should go into multiverse.

Revision history for this message

Scott Moser (smoser) wrote on 2011-06-14:

#2

I have a signed source package available at
http://people.canonical.com/~smoser/bugs/797387/ .

The same content is available at lp:~awstools-dev/ubuntu/oneiric/rdscli/oneiric

Andres Rodriguez (andreserl) on 2011-06-15

Changed in ubuntu:
assignee:	nobody → Andres Rodriguez (andreserl)
status:	New → In Progress

Andres Rodriguez (andreserl) on 2011-06-15

Changed in ubuntu:
status:	In Progress → Fix Committed
assignee:	Andres Rodriguez (andreserl) → nobody

Revision history for this message

Micah Gersten (micahg) wrote on 2011-06-15:

#3

Download full text (8.2 KiB)

You have a lot of lintian warnings that should be fixed before this is accepted into the archive:
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/log4j.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-logging-1.0.4.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xmlsec-1.4.2.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/wstx-asl-3.2.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-cli-1.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jaxws-api-2.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jaxb-impl-2.0.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/stax-api-1.0.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-codec-1.3.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jaxb-api-2.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xalan-j2-2.7.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/wsdl4j-1.6.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/activation-1.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/serializer.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/wss4j-1.5.7.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-httpclient-3.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/CliCommando-1.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xfire-all-1.2.6.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jdom-1.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xfire-jsr181-api-1.0-M1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-discovery-0.2.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/service.jar
W: rdscli: manpage-has-bad-whatis-entry usr/share/man/man1/rds-describe-orderable-db-instance-options.1.gz
N: Processing source package rdscli (version 1.4.006-0ubuntu1) ...
P: rdscli source: duplicate-in-relation-field in rdscli depends: libcommons-logging-java, libcommons-logging-java
N:
N: The given field in the debian/control file contains relations that are
N: either identical or imply each other. The less restrictive one can be
N: removed. This is done automatically by dpkg-source and dpkg-gencontrol,
N: so this does not affect the generated package.
N:
N: Severity: pedantic, Certainty: certain
N:
P: rdscli source: unneeded-build-dep-on-quilt
N:
N: This package build-depends on quilt, which is not required since
N: dpkg-source will apply patches at unpack time for 3.0 (quilt) source
N: packages.
N:
N: Remember to remove any references to quilt in the rules file (e.g.
N: "--with quilt", dh_quilt_* or quilt makefile includes).
N:
N: This tag is meant to remind people that with 3.0 (quilt), quilt is not
N: necessary. If you keep the build-depends on quilt to ease backporting to
N: older releases, then please ignore/override this tag.
N:
N: Severity: pedantic, Certainty: possible
N:
I: rdscli source: quilt-patch-missing-description add-makefile.patch
N:
N: quilt patch files should start with a description of patch. All lines
N: before the start of the patch itself are considered part of the
N: description. You can edit the description with quilt header -e when the
N: patch is at the top of th...

You have a lot of lintian warnings that should be fixed before this is accepted into the archive:
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/log4j.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-logging-1.0.4.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xmlsec-1.4.2.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/wstx-asl-3.2.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-cli-1.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jaxws-api-2.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jaxb-impl-2.0.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/stax-api-1.0.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-codec-1.3.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jaxb-api-2.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xalan-j2-2.7.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/wsdl4j-1.6.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/activation-1.1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/serializer.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/wss4j-1.5.7.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-httpclient-3.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/CliCommando-1.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xfire-all-1.2.6.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/jdom-1.0.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/xfire-jsr181-api-1.0-M1.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-discovery-0.2.jar
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/service.jar
W: rdscli: manpage-has-bad-whatis-entry usr/share/man/man1/rds-describe-orderable-db-instance-options.1.gz
N: Processing source package rdscli (version 1.4.006-0ubuntu1) ...
P: rdscli source: duplicate-in-relation-field in rdscli depends: libcommons-logging-java, libcommons-logging-java
N: 
N:    The given field in the debian/control file contains relations that are
N:    either identical or imply each other. The less restrictive one can be
N:    removed. This is done automatically by dpkg-source and dpkg-gencontrol,
N:    so this does not affect the generated package.
N:    
N:    Severity: pedantic, Certainty: certain
N: 
P: rdscli source: unneeded-build-dep-on-quilt
N: 
N:    This package build-depends on quilt, which is not required since
N:    dpkg-source will apply patches at unpack time for 3.0 (quilt) source
N:    packages.
N:    
N:    Remember to remove any references to quilt in the rules file (e.g.
N:    "--with quilt", dh_quilt_* or quilt makefile includes).
N:    
N:    This tag is meant to remind people that with 3.0 (quilt), quilt is not
N:    necessary. If you keep the build-depends on quilt to ease backporting to
N:    older releases, then please ignore/override this tag.
N:    
N:    Severity: pedantic, Certainty: possible
N: 
I: rdscli source: quilt-patch-missing-description add-makefile.patch
N: 
N:    quilt patch files should start with a description of patch. All lines
N:    before the start of the patch itself are considered part of the
N:    description. You can edit the description with quilt header -e when the
N:    patch is at the top of the stack.
N:    
N:    As well as a description of the purpose and function of the patch, the
N:    description should ideally contain author information, a URL for the bug
N:    report (if any), Debian or upstream bugs fixed by it, upstream status,
N:    the Debian version and date the patch was first included, and any other
N:    information that would be useful if someone were investigating the patch
N:    and underlying problem. Please consider using the DEP-3 format for this
N:    information.
N:    
N:    Refer to http://dep.debian.net/deps/dep3/ for details.
N:    
N:    Severity: wishlist, Certainty: certain
N: 
W: rdscli source: out-of-date-standards-version 3.9.1 (current is 3.9.2)
N: 
N:    The source package refers to a Standards-Version older than the one that
N:    was current at the time the package was created (according to the
N:    timestamp of the latest debian/changelog entry). Please consider
N:    updating the package to current Policy and setting this control field
N:    appropriately.
N:    
N:    If the package is already compliant with the current standards, you
N:    don't have to re-upload the package just to adjust the Standards-Version
N:    control field. However, please remember to update this field next time
N:    you upload the package.
N:    
N:    See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N:    debian-policy package for a summary of changes in newer versions of
N:    Policy.
N:    
N:    Severity: normal, Certainty: certain
N: 
I: rdscli source: debian-watch-file-is-missing
N: 
N:    This source package is not Debian-native but it does not have a
N:    debian/watch file. This file is used for automatic detection of new
N:    upstream versions by the Debian External Health Status project and other
N:    project infrastructure. If this package is maintained upstream, please
N:    consider adding a debian/watch file to detect new releases.
N:    
N:    If the package is not maintained upstream or if upstream uses a
N:    distribution mechanism that cannot be meaningfully monitored by uscan
N:    and the Debian External Health Status project, please consider adding a
N:    debian/watch file containing only comments documenting the situation.
N:    
N:    Refer to Debian Policy Manual section 4.11 (Optional upstream source
N:    location: debian/watch) and the uscan(1) manual page for details.
N:    
N:    Severity: wishlist, Certainty: certain
N: 
I: rdscli: spelling-error-in-manpage usr/share/man/man1/rds-create-db-parameter-group.1.gz paramter parameter
N: 
N:    Lintian found a spelling error in the manpage. Lintian has a list of
N:    common misspellings that it looks for. It does not have a dictionary
N:    like a spelling checker does.
N:    
N:    If the string containing the spelling error is translated with the help
N:    of gettext (with the help of po4a, for example) or a similar tool,
N:    please fix the error in the translations as well as the English text to
N:    avoid making the translations fuzzy. With gettext, for example, this
N:    means you should also fix the spelling mistake in the corresponding
N:    msgids in the *.po files.
N:    
N:    Severity: minor, Certainty: possible
N: 
W: rdscli: manpage-has-bad-whatis-entry usr/share/man/man1/rds-describe-orderable-db-instance-options.1.gz
N: 
N:    Each manual page should start with a "NAME" section, which lists the
N:    name and a brief description of the page separated by "\-". The "NAME"
N:    section is parsed by lexgrog and used to generate a database that's
N:    queried by commands like apropos and whatis. This tag indicates that
N:    lexgrog was unable to parse the NAME section of this manual page.
N:    
N:    For manual pages that document multiple programs, functions, files, or
N:    other things, the part before "\-" should list each separated by a comma
N:    and a space. Each thing listed must not contain spaces; a man page for a
N:    two-part command like "fs listacl" must use something like "fs_listacl"
N:    in the "NAME" section so that it can be parsed by lexgrog.
N:    
N:    Refer to the lexgrog(1) manual page, the groff_man(7) manual page, and
N:    the groff_mdoc(7) manual page for details.
N:    
N:    Severity: normal, Certainty: certain
N: 
W: rdscli: jar-not-in-usr-share usr/lib/rdscli/log4j.jar
N: 
N:    The classpath listed in some of the files references files outside of
N:    /usr/share, while all installed JAR files must be within /usr/share/java
N:    for libraries or /usr/share/<package> for JARs for private use.
N:    
N:    The rationale is that jar files are in almost all cases architecture
N:    independent and therefore should be in /usr/share. If the jar file is
N:    truly architecture dependent or it cannot be moved since symlinked jar
N:    files are not accepted by the application, then please override this
N:    tag.
N:    
N:    Refer to Debian Java Policy section 2.2 (Debian Java Policy) and Debian
N:    Java Policy section 2.3 (Debian Java Policy) for details.
N:    
N:    Severity: normal, Certainty: possible
N:

unsubscribing ubuntu-sponsors until these are fixed

Changed in ubuntu:
status:	Fix Committed → Incomplete

Revision history for this message

Micah Gersten (micahg) wrote on 2011-06-15:

#4

Also, please use wrap-and-sort from ubuntu-dev-tools.

Revision history for this message

Scott Moser (smoser) wrote on 2011-06-16: Re: [Bug 797387] Re: [needs-packaging] rdscli

#5

On Wed, 15 Jun 2011, Micah Gersten wrote:

> You have a lot of lintian warnings that should be fixed before this is accepted into the archive:
> W: rdscli: jar-not-in-usr-share usr/lib/rdscli/log4j.jar
> W: rdscli: jar-not-in-usr-share usr/lib/rdscli/commons-logging-1.0.4.jar
...
These are all fixed now. jar files moved to /usr/share/rdscli

> W: rdscli: manpage-has-bad-whatis-entry usr/share/man/man1/rds-describe-orderable-db-instance-options.1.gz

I don't see this error, but I'd prefer to ignore it. The man pages are
generated from help output.

> N: Processing source package rdscli (version 1.4.006-0ubuntu1) ...
> P: rdscli source: duplicate-in-relation-field in rdscli depends: libcommons-logging-java, libcommons-logging-java

Fixed.

> P: rdscli source: unneeded-build-dep-on-quilt

Fixed.

> I: rdscli source: quilt-patch-missing-description add-makefile.patch

Fixed.

> W: rdscli source: out-of-date-standards-version 3.9.1 (current is 3.9.2)

Fixed.

> I: rdscli source: debian-watch-file-is-missing

Not really possible. The only upstream listing that is available here is
s3 based xml output. To address that, there is a
'debian/rules upstream-check', but this really can't be handled by uscan.

> I: rdscli: spelling-error-in-manpage usr/share/man/man1/rds-create-db-parameter-group.1.gz paramter parameter

man pages come generated from '--help' output. I'd rather specifically
address it via some hack.

Revision history for this message

Scott Moser (smoser) wrote on 2011-06-16:

#6

whoops:
- I'd rather specifically address it via some hack.
+ I'd rather NOT specifically address it via some hack.

the content on people.canonical has been updated as well as the branch listed above.

Micah Gersten (micahg) on 2011-06-16

Changed in ubuntu:
importance:	Undecided → Wishlist
status:	Incomplete → Confirmed

Revision history for this message

Micah Gersten (micahg) wrote on 2011-06-16:

#7

Thank you for these quick updates. The only other thing I see since we can't do a watch file (maybe there should be a bug filed so that we can in the future), is a README.source file, like some of the other packages you mentioned, that explains how to update the package in the archive.

Also, about the manpage, I can verify it produces bad output, but I'm not sure on the source. I'm ok with leaving that for now.

Changed in ubuntu:
assignee:	nobody → Scott Moser (smoser)
status:	Confirmed → Incomplete

Revision history for this message

Scott Moser (smoser) wrote on 2011-06-16:

#8

I've added a reasonably complete debian/README.source and also fixed the manpage error. The problem was that there was an empty description for that command. I've modified the creation of the man pages to fail in that situation so it should not occur again.

Revision history for this message

Scott Moser (smoser) wrote on 2011-06-16:

#9

$ lintian --pedantic rdscli_1.4.006-0ubuntu1.dsc
$ lintian --pedantic rdscli_1.4.006-0ubuntu1_all.deb
P: rdscli: no-upstream-changelog

That looks better.

Changed in ubuntu:
status:	Incomplete → New

Revision history for this message

Scott Moser (smoser) wrote on 2011-06-16:

#10

regarding uscan, i opened bug 798293.
There is a patch/merge proposal attached.

Revision history for this message

Micah Gersten (micahg) wrote on 2011-06-20:

#11

I still get the manpage error with the lintian on oneiric, but I uploaded it anyway since this is minor. Thank you for packaging this!

Changed in ubuntu:
assignee:	Scott Moser (smoser) → nobody
status:	New → Fix Committed

Mathew Hodson (mhodson) on 2016-07-17

tags:	added: needs-packaging
affects:	ubuntu → rdscli (Ubuntu)
Changed in rdscli (Ubuntu):
status:	Fix Committed → Fix Released

Ubuntu
rdscli package

[needs-packaging] rdscli

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Ubunturdscli package

[needs-packaging] rdscli

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Ubuntu
rdscli package