Launchpad itself

Asynchronous PPA copying with default series OOPSes

Bug #795005 reported by Julian Edwards
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Colin Watson

Bug Description

Similar to bug 792002 but in this case the page OOPSes immediately if you're copying enough packages to warrant an async copy and the destination series is left at the default (existing) series.

Worked around in production with:
soyuz.derived_series.max_synchronous_syncs default 0 1000000

to prevent async copying.

Tags: oops ppa qa-ok

Related branches

lp:~cjwatson/launchpad/copy-packages-with-default-series
Jelmer Vernooij (community): Approve (code)
Diff: 397 lines (+135/-53)
8 files modified
lib/lp/registry/browser/distroseries.py (+2/-2)
lib/lp/soyuz/browser/archive.py (+3/-5)
lib/lp/soyuz/browser/tests/test_package_copying_mixin.py (+29/-0)
lib/lp/soyuz/model/archive.py (+8/-18)
lib/lp/soyuz/model/packagecopyjob.py (+6/-6)
lib/lp/soyuz/scripts/packagecopier.py (+40/-19)
lib/lp/soyuz/tests/test_archive.py (+43/-0)
lib/lp/soyuz/tests/test_packagecopyjob.py (+4/-3)
lp:~cjwatson/launchpad/fix-check-copy-permissions
William Grant: Approve (code)
Diff: 219 lines (+84/-43)
6 files modified
lib/lp/archiveuploader/nascentupload.py (+1/-1)
lib/lp/soyuz/interfaces/queue.py (+1/-1)
lib/lp/soyuz/model/queue.py (+5/-6)
lib/lp/soyuz/scripts/packagecopier.py (+33/-25)
lib/lp/soyuz/tests/test_archive.py (+33/-0)
lib/lp/soyuz/tests/test_packagecopyjob.py (+11/-10)
Julian Edwards (julian-edwards)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
tags: added: ppa
Julian Edwards (julian-edwards)
tags: added: oops
Robert Collins (lifeless)
Changed in launchpad:
importance: High → Critical
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Not critical because you can't actually do this in production yet.

Changed in launchpad:
importance: Critical → High
Revision history for this message
Robert Collins (lifeless) wrote :

Our policy around this doesn't say anything about in production or not - just that things which oops, get tagged oops and marked critical; I agree, if you suggest that the policy may need tweaking, but *as it stands*, this is tagged oops, refers to oopses, and should be critical.

Changed in launchpad:
importance: High → Critical
Revision history for this message
Robert Collins (lifeless) wrote :

(Note that having this critical is not just per-policy, it is consistent with how we have criticals for other things which can be worked around by temporary config settings - the defect is real, and the code needs to be fixed). One way to fix is it to teach the code to never try async for ppa copies, until someone sits down to work properly on the feature.

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 795005] Re: Asynchronous PPA copying with default series OOPSes

On Thursday 15 Mar 2012 08:50:38 you wrote:
> Our policy around this doesn't say anything about in production or not -
> just that things which oops, get tagged oops and marked critical; I
> agree, if you suggest that the policy may need tweaking, but *as it
> stands*, this is tagged oops, refers to oopses, and should be critical.
>
> ** Changed in: launchpad
> Importance: High => Critical

The reason I changed it back to high is because it's unimplemented to do PPA
copying asynchronously. It's not an OOPS by any description that we currently
have, it's not a bug, it's just unimplemented.

Feel free to keep priority as you wish.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Thursday 15 Mar 2012 09:06:38 you wrote:
> (Note that having this critical is not just per-policy, it is consistent
> with how we have criticals for other things which can be worked around
> by temporary config settings - the defect is real, and the code needs to
> be fixed). One way to fix is it to teach the code to never try async for
> ppa copies, until someone sits down to work properly on the feature.

The code already does that :) (the feature flag is a red herring)

Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15523 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15523>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15530 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15530) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Colin Watson (cjwatson) wrote :

fix-check-copy-permissions looks fine; I removed myself from ubuntu-core-dev and was able to copy a new version of a package from a PPA that was already published in universe, but not one that was published in main.

tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: In Progress → Fix Released
Revision history for this message
Julian Edwards (julian-edwards) wrote :

One of the reasons I didn't fix this yet is because it needed a way to present failed copy jobs to the user. How did you solve that?

Revision history for this message
Colin Watson (cjwatson) wrote :

You filed bug 812869 for that part of the work.

(It looks like Raphaël fixed most of that a while back, but there's a little bit of work left to hook it up properly.)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.