spurious algorithm in diagnostic_algorithms

Bug #788620 reported by Jonathan Bull
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fluidity
Fix Released
Low
Patrick Farrell

Bug Description

Somehow this line crept in at the bottom of diagnostic_algorithms.rnc:
tensor_diagnostic_algorithm = tensor_squared_time_averaged_algorithm
It needs to be removed as there is no such algorithm.

Jonathan Bull (j-bull08)
Changed in fluidity:
importance: Undecided → Low
Revision history for this message
Patrick Farrell (pefarrell) wrote :

It looks like before I sorted the available diagnostics, it was called "vector_squared_time_averaged_algorithm" (even though it was marked as a diagnostic for a tensor field). It was added in r2725 by Dimitrios with the message

------------------------------------------------------------
revno: 2725
svn revno: 2769 (on /trunk)
committer: dp204
timestamp: Tue 2011-01-18 12:32:35 +0000
message:
  new diagnostics: time averaged scalar, vector, scalar squared, vector squared (this is a tensor including cross-products) and vector times scalar (for evaluating stuff like \overline{uT}) fields. These are interpolated between adapts. They don't like checkpointing for now. Totally untested.

Now, if there was any test using it, the diamond_validation test would have failed, and so I conclude that it is not tested. If that is the case, we should just delete it. In the meantime, I'll rename it.

Revision history for this message
Patrick Farrell (pefarrell) wrote :

Related: r3480

Revision history for this message
Tim Bond (timothy-bond) wrote :

Is there any interest in removing these (they do appear to be untested) or should this bug be closed as-is?

Revision history for this message
Patrick Farrell (pefarrell) wrote :

Removed in r3893.

Changed in fluidity:
status: New → Fix Committed
Tim Bond (timothy-bond)
Changed in fluidity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.