APITest: Non-integer high score fails silently

Bug #788563 reported by Scott Ritchie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MUGLE
Fix Released
Low
Matt Giuca

Bug Description

As a mature educated individual the first highscore i submitted was "over 9000", only to find that not only did it not save my incredible score, it didnt throw an error to the UI that i wasn't giving it an integer.

Related branches

Revision history for this message
Matt Giuca (mgiuca) wrote :

OK but is this just a UI issue? Looking at the data store, it looks like that value wasn't stored, so it's just a matter of providing feedback.

Also, how did you submit it? Did you write your own app, or use the APITest? This might just be a bug in the API tester, because the HighscoreService takes an Integer; GWT would surely raise an error. So it's possibly not a MUGLE bug at all.

Revision history for this message
Scott Ritchie (sritchie) wrote : Re: [Bug 788563] Re: passing a non-integer to save highscore doesnt throw an error

I used the API tester, but shouldn't the error be displayed? it has been in
every other field in the API tester i tried.

On Thu, May 26, 2011 at 9:23 PM, Matt Giuca <email address hidden>wrote:

> OK but is this just a UI issue? Looking at the data store, it looks like
> that value wasn't stored, so it's just a matter of providing feedback.
>
> Also, how did you submit it? Did you write your own app, or use the
> APITest? This might just be a bug in the API tester, because the
> HighscoreService takes an Integer; GWT would surely raise an error. So
> it's possibly not a MUGLE bug at all.
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/788563
>
> Title:
> passing a non-integer to save highscore doesnt throw an error
>
> Status in Melbourne University Game-based Learning Environment:
> New
>
> Bug description:
> As a mature educated individual the first highscore i submitted was
> "over 9000", only to find that not only did it not save my incredible
> score, it didnt throw an error to the UI that i wasn't giving it an
> integer.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/mugle/+bug/788563/+subscribe
>

Revision history for this message
Matt Giuca (mgiuca) wrote : Re: passing a non-integer to save highscore doesnt throw an error

Yes, but all of the other fields are sending strings to the server, and the server is sending back an error response. For this field, the client is parsing it into an int, and failing silently -- it never sends a request to the server. So this is an APITest bug, not a MUGLE bug. Fixing it now.

Changed in mugle:
assignee: nobody → Matt Giuca (mgiuca)
importance: Undecided → Low
milestone: none → 0.2
status: New → In Progress
summary: - passing a non-integer to save highscore doesnt throw an error
+ APITest: Non-integer high score fails silently
Revision history for this message
Matt Giuca (mgiuca) wrote :

Fixed in trunk r462.

Changed in mugle:
status: In Progress → Fix Committed
Matt Giuca (mgiuca)
Changed in mugle:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.