The project/pillar chooser is missing of application root pages
Bug #787856 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Curtis Hovey | ||
Bug Description
While reviewing Bug 376671, bug 442423, and bug 541979 I discovered that the choose link is not rendered next to the project/pillar field on bugs an answers front pages.
This affects bugs, blueprints, and answers.
Related branches
lp:~sinzui/launchpad/project-picker-0
- Jeroen T. Vermeulen (community): Approve (code)
- Ian Booth (community): Approve (code*)
- Diff: 0 lines
| description: | updated |
| description: | updated |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: |
added: target-picker removed: project-picker |
| tags: | added: disclosure |
To post a comment you must log in.
I am not certain of what changed or when, but I know what is wrong. The ProjectScopeWidget is being setup correctly, but the templates do not ever use __call__() to render the widget and the supporting js. Neither the widget or the three broken templates have changed in years. I conclude the the supporting js that was assumed to be loaded was removed. This is a very old widget that predates YUI and maybe MochiKit. Refactoring to remove old scripts, or change how we included scripts into the page broke these three pages.
The fix is trivial now that I understand what is wrong. The templates avoid __call__ because they are contriving a layout. The layout can be achieved be changing the table and using the widget is the standard fashion.