Picker widget show_widget_id generation
Bug #787389 reported by
Ian Booth
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Ian Booth |
Bug Description
The fix for bug 777766 breaks existing Windmill tests and also makes new tests extremely hard to write because the show_widget_id attribute is no longer discoverable from the field name. The fix uses a base63 encoding to convert the field to non-human readable text.
The point of the fix was to remove invalid characters from the field name so that a valid HTML node id could be generated from the field name. This needs to be done another way so that developers can still relate the generated show_widget_id value back to the associated field name. Otherwise windmill tests which rely on this known mapping break.
Related branches
lp:~wallyworld/launchpad/better-popup-show-widget-name
- Curtis Hovey (community): Approve (code)
- Benji York: Pending requested
-
Diff: 335 lines (+123/-44)4 files modifiedlib/lp/app/browser/stringformatter.py (+45/-9)
lib/lp/app/doc/tales.txt (+17/-7)
lib/lp/app/widgets/popup.py (+6/-15)
lib/lp/app/widgets/tests/test_popup.py (+55/-13)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r13138 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 13138>.