"Mark as spam" text is unclear about actual action
Bug #782252 reported by
j.c.sackett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
j.c.sackett | ||
Bug Description
The new comment hiding controls for admins shows "Mark as spam" as the text. This doesn't make it entirely clear that clicking it will hide the message--some might confuse it to mean flagging the comment for review.
The text should just be "Hide comment"
Related branches
lp:~jcsackett/launchpad/consolidate-spam-js
- Benji York (community): Approve (code)
-
Diff: 820 lines (+140/-421)16 files modifiedlib/lp/answers/browser/configure.zcml (+1/-1)
lib/lp/answers/browser/tests/test_questionmessages.py (+2/-0)
lib/lp/answers/interfaces/questionmessage.py (+9/-5)
lib/lp/answers/javascript/question_spam.js (+0/-73)
lib/lp/answers/model/questionmessage.py (+5/-1)
lib/lp/answers/templates/question-index.pt (+3/-2)
lib/lp/answers/templates/questionmessage-display.pt (+6/-10)
lib/lp/app/javascript/hide_comment.js (+72/-0)
lib/lp/app/javascript/tests/test_hide_comment.html (+9/-38)
lib/lp/app/javascript/tests/test_hide_comment.js (+20/-20)
lib/lp/bugs/javascript/bug_spam.js (+0/-72)
lib/lp/bugs/javascript/tests/test_bug_spam.html (+0/-94)
lib/lp/bugs/javascript/tests/test_bug_spam.js (+0/-93)
lib/lp/bugs/templates/bugcomment-box.pt (+4/-6)
lib/lp/bugs/templates/bugtask-index.pt (+3/-2)
lib/lp/coop/answersbugs/visibility.py (+6/-4)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → j.c.sackett (jcsackett) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: disclosure information-type |
To post a comment you must log in.
Fixed in stable r13076 <http://