branch upgrade jobs keep transaction open
Bug #777958 reported by
Aaron Bentley
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Aaron Bentley |
Bug Description
Branch upgrade jobs keep the database transaction open, which means that if they run for a long time, the connection will be killed due to inactivity/timeout, generating an oops. OOPS-1950UBJ1 is an example.
Either we should forbid upgrade jobs from running so long, or we should ensure that they make a new connection to indicate that they are complete.
Related branches
lp:~abentley/launchpad/safe-branch-upgrade
- Deryck Hodge (community): Approve (code)
-
Diff: 275 lines (+112/-23)4 files modifiedlib/lp/code/model/branchjob.py (+8/-4)
lib/lp/code/model/tests/test_branchjob.py (+9/-18)
lib/lp/scripts/helpers.py (+42/-1)
lib/lp/scripts/tests/test_helpers.py (+53/-0)
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
tags: | added: critical-analysis |
To post a comment you must log in.
Woo! This also provides *an* explanation for prior branch contention
issues that occur infrequently.