os-prober doesn't detect Windows partition but the recovery partition instead

still an issue with Oneiric Beta 1

Please attach (or mail me privately) the /boot/bcd files on each of /dev/sda2 and /dev/sda3.

Here is boot/bcd from sda2. It doesn't exist on /dev/sda3

In that case, this is correct behaviour from os-prober. It's supposed to return the thing you can boot. In this case, the Windows boot loader is on sda2, so it returned that.

Ubiquity is going to need to change to track down the actual Windows root filesystem associated with a boot partition (somewhat like the way linux-boot-prober tracks down more information for Linux boot partitions). However, I'm going to bump this to P-series, as I think this is going to be too invasive for Oneiric, although I realise it's a problem.

I agree. It's far too late to fix this in ubiquity for Oneiric.

output of os-prober
/dev/sda2:Windows 7 (loader):Windows:chain

I have a fix for the wubi part of the bug, tested to work here with Windows 8 + recovery.

Got it working here. Here are the changes required:

ubiquity: http://paste.ubuntu.com/915020/
os-prober: http://paste.ubuntu.com/915023/
migration-assistant: http://paste.ubuntu.com/915030/

I made it an environment variable instead of a command parameter as os-prober currently doesn't have any parameters and the environment variable seemed like the easiest way of getting the feature with a minimal amount of changes.

The wubi part of the fix mentioned above is already in ubiquity's trunk branch as I'm pretty sure it was the right way of fixing it and I confirmed it to be working. That commit also fixed 2-3 other bugs I found in that specific part of the code but that weren't reported that I could find.
That's:
 - ubiquity doesn't reboot when clicking on the continue/restart button after selecting wubi
 - wubi check fails when you have more than one Windows partition

Post-install result looks like it worked, install succeeded and I see some Windows looking directories in my user's Documents directory, though no specific content as my Windows install doesn't contain any.

This bug was fixed in the package os-prober - 1.51ubuntu3

---------------
os-prober (1.51ubuntu3) precise; urgency=low

  * When called with WINOSDATA, return the list of Windows partitions
    containing the system instead of only listing these containing the
    bootrecord. (LP: #772470)
 -- Stephane Graber <email address hidden> Wed, 04 Apr 2012 18:34:56 -0400

This bug was fixed in the package migration-assistant - 0.6.12

---------------
migration-assistant (0.6.12) precise; urgency=low

  * Call os-prober with WINOSDATA set to true so that we only get a list
    of Windows partitions containing the OS instead of only these containing
    the boot record. (LP: #772470)
 -- Stephane Graber <email address hidden> Wed, 04 Apr 2012 18:38:32 -0400

This bug was fixed in the package ubiquity - 2.10.7

---------------
ubiquity (2.10.7) precise; urgency=low

  [ Colin Watson ]
  * Fix partman plugin to preseed grub-installer/bootdev in a cleanup method
    rather than exit_ui_loops, since talking to debconf in the latter isn't
    safe (LP: #792652). Adjust how maybe_update_grub gets the default boot
    device to avoid regressing LP #756920.

  [ Stéphane Graber ]
  * Add support for Windows 8 user directory detection.
  * Make wubi work when the OS data partition is different from the boot
    partition. (LP: #772470)
  * Call gsettings through dbus-launch in an hope to ensure its changes
    are saved to disk. (LP: #960096)
  * Make ubiquity depend on dbus-x11 for dbus-launch.
  * Update compat/os-proper to make a different cache when listing OS
    data partitions. (LP: #772470)
  * Automatic update of included source packages: migration-assistant
    0.6.12.
 -- Stephane Graber <email address hidden> Wed, 04 Apr 2012 20:56:08 -0400