Ubuntu
ubuntu-sso-client package

[SRU] missing dependency on gnome-keyring

Bug #769520 reported by Harald Sitter
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-sso-client (Ubuntu)
Fix Released
Medium
Natalia Bidart
Ubuntu natty-updates
Natty
Fix Released
Low
Unassigned

Bug Description

Binary package hint: ubuntu-sso-client

In natty only gnome-keyring provides org.freedesktop.secrets, which is used by ubuntu-sso-client, so it must depend on gnome-keyring as otherwise it silently fails to do anything, rendering it absolutely and utterly broken to the user.

Related branches

lp:~nataliabidart/ubuntu/natty/ubuntu-sso-client/add-gnome-keyring
Ubuntu Sponsors: Pending requested
Diff: 27 lines (+9/-0)
2 files modified
debian/changelog (+8/-0)
debian/control (+1/-0)
lp:ubuntu/natty-proposed/ubuntu-sso-client
Revision history for this message
Harald Sitter (apachelogger) wrote :

In particular the log shows:

2011-04-23 16:39:23,152:152.550935745 - ubuntu_sso.main - ERROR - CredentialsManagement: emitting CredentialsError with app_name "Ubuntu One" and error_dict {'errtype': 'DBusException', 'message': 'The name org.freedesktop.secrets was not provided by any .service files'}.

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Hi Harald,

Thanks for the report. I was hoping we could depend on a virtual package that can be provided by either gnome-keyring or any other keyring service that confirms the Secrets API.

Would you know if such virtual package exists?

Natalia.

Changed in ubuntu-sso-client (Ubuntu):
status: New → Confirmed
status: Confirmed → Incomplete
assignee: nobody → Naty Bidart (nataliabidart)
Revision history for this message
Harald Sitter (apachelogger) wrote :

Yes, I was thinking the very same thing.

There is no virtual package yet; I am not sure we should introduce one for natty as gnome-keyring is the only package that actually implements the xdg-secrets-api at this point. As a quick fix for natty I think depending on gnome-keyring directly ought to be sufficient.

When ksecretservice (KDE's impl) arrives we will have to introduce a virtual package anyway and also coordinate naming with Debian so we do not end up with different names. As the spec is not stable yet and currently KSS does not even implement all interfaces, I do not think this is going to be any time soon though :).

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Makes sense to fix the natty package depending on gnome-keyring, I'll propose a branch soon (it may take some time until is approved due to the incoming release).

Changed in ubuntu-sso-client (Ubuntu):
status: Incomplete → Triaged
importance: Undecided → Medium
Natalia Bidart (nataliabidart)
summary: - missing dependency on gnome-keyring
+ [SRU] missing dependency on gnome-keyring
Changed in ubuntu-sso-client (Ubuntu):
milestone: none → ubuntu-11.04
status: Triaged → New
Kate Stewart (kate.stewart)
Changed in ubuntu-sso-client (Ubuntu):
milestone: ubuntu-11.04 → natty-updates
Sebastien Bacher (seb128)
Changed in ubuntu-sso-client (Ubuntu Natty):
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Please fix in oneiric, so that this can progress to -updates.

tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted ubuntu-sso-client into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Harald Sitter (apachelogger) wrote :

Works for me.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Natty:
I have reproduced the problem with ubuntu-sso-client 1.2.1-0ubuntu1 in natty and have verified that the version of ubuntu-sso-client 1.2.1-0ubuntu2 in -proposed fixes the issue.

Marking as verification-done

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-sso-client - 1.2.1-0ubuntu2

---------------
ubuntu-sso-client (1.2.1-0ubuntu2) natty-proposed; urgency=low

  * debian/control
    - add gnome-keyring as Depends since is, for now, the only package that
    provides the org.freedesktop.secrets DBus service (LP: #769520).
 -- Natalia Bidart (nessita) <email address hidden> Tue, 26 Apr 2011 08:48:51 -0300

Changed in ubuntu-sso-client (Ubuntu Natty):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Copied to oneiric as well.

Changed in ubuntu-sso-client (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.