Evergreen

pre_cat_fields.xul buttons not visible when number of characters in code : name : description dropdown exceeds horizontal pixels of screen resolution

Bug #767507 reported by Michael Peters on 2011-04-20

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Evergreen	Status tracked in Main
2.0	Fix Released	Undecided	Unassigned
2.1	Fix Released	Undecided	Unassigned
2.2	Fix Released	Undecided	Unassigned	Evergreen 2.2.0alpha1
Main	Fix Released	Undecided	Michael Peters	Evergreen 2.2.0alpha1

Bug Description

Evergreen 2.0.4
OpenSRF 1.6.3

File impacted is pre_cat_fields.xul.

Discovered in Indiana when we applied a few short descriptions to the config.circ_modifier table. When on some 800x600 screens you're unable to perform "Check out" due to the fact that the width of the "Circ Modifier" dropdown is approximately 921px.

As you can see from the screenshot, it doesn't appear we're using an extremely long description for these, but perhaps another method for displaying the description (tooltip?) is in order.

Revision history for this message

Michael Peters (mrpeters) wrote on 2011-04-20:

Pre-cat Dropdown Width Edit (846.8 KiB, image/jpeg)

Revision history for this message

Michael Peters (mrpeters) wrote on 2011-04-20:

800600precat.jpg Edit (237.3 KiB, image/jpeg)

Additonal screenshot, showing how this impacts an 800x600 monitor.

Revision history for this message

Michael Peters (mrpeters) wrote on 2011-04-25:

Adds overflow scroll bars to pre_cat_fields.xul Edit (729 bytes, text/plain)

All,

Admittedly, this isn't the most elegant of solutions but it is a solution no less. This small patch adds an automatic overflow to the pre_cat_fields.xul so users can always resort to scrolling to access the rest of the window.

Perhaps we could consider this as a suitable fix in future versions. The 'ugly' scrolling only occurs when your window width is smaller than that of the descriptions in the Circ Modifier dropdown so while this may hurt a bit cosmetically, it does help functionality.

Hope others find this helpful if they run into this in the future.

Changed in evergreen:
status:	New → In Progress
assignee:	nobody → Michael Peters (mrpeters)

Revision history for this message

Mike Rylander (mrylander) wrote on 2011-05-04:

Committed as-is for now, trunk through 2.0, and leaving in-progress for later adjustment.

Revision history for this message

Jason Boyer (jasonb-myjclibrary) wrote on 2011-05-05:

Is there currently a util function for extracting part of the circ mod (or any kind of param to the server call that returns it)? I would think that just the Name (or Code, not certain what the distinction is intended to be) would be used everywhere in the staff client, and the Description would be used in the OPAC (including in the staff client).

Revision history for this message

Jason Etheridge (phasefx) wrote on 2011-05-05:

In common.properties:
# %1$s = circ modifier code, %2$s = circ modifier name, %3$s = circ modifier description
staff.circ_modifier.display=%1$s : %2$s : %3$s

You can override this without editing common.properties directly by creating a common_custom.properties in the same directory and adding a line like so:
staff.circ_modifier.display=%1$s