do_copy() cannot run be asynchronously. Sort it out.

Bug #766247 reported by Gavin Panella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella

Bug Description

Pony ride on DistributionJob, where the distribution and distroseries
are *destinations*. do_copy()'s signature is:

def do_copy(sources, archive, series, pocket, include_binaries=False,
            allow_delayed_copies=True):

It runs quickly, so there's no need to check on progress, so it
doesn't matter much that this doesn't map well onto DistributionJob.

Important: calls to do_copy() must not be made concurrently for the
same target archive. For now ensure that the job runner runs all
do_copy() jobs serially.

Related branches

Revision history for this message
Gavin Panella (allenap) wrote :

StevenK has said that SyncPackageJob is not used, so I'll just modify that.

Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.05
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

Code not yet used, so OK to deploy.

tags: added: qa-untestable
removed: qa-needstesting
Brad Crittenden (bac)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.