incomplete-with-response searches require complex searches
Bug #759467 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Brad Crittenden | ||
Bug Description
We currently generate queries like
status = foo or status = bar or (status = 10 and date_last_comment < ..) or (status=10 and date_last_comment is NULL).. this is cross-table and complex.
We should set the actual status field in the bugtasks when a response is received rather than inferring it. This allows:
- setting the status back to incomplete-
- simpler and more efficient querying.
Related branches
lp:~lifeless/launchpad/bug-759467
- Gavin Panella (community): Approve
-
Diff: 917 lines (+268/-120)19 files modifieddatabase/schema/security.cfg (+1/-0)
lib/canonical/config/schema-lazr.conf (+1/-1)
lib/canonical/database/enumcol.py (+29/-12)
lib/canonical/launchpad/doc/enumcol.txt (+35/-3)
lib/lp/bugs/browser/bugtask.py (+1/-52)
lib/lp/bugs/browser/tests/bugs-views.txt (+1/-1)
lib/lp/bugs/configure.zcml (+1/-0)
lib/lp/bugs/doc/bugtask-status-workflow.txt (+1/-1)
lib/lp/bugs/interfaces/bugtask.py (+19/-11)
lib/lp/bugs/model/bug.py (+10/-2)
lib/lp/bugs/model/bugtarget.py (+14/-1)
lib/lp/bugs/model/bugtask.py (+69/-30)
lib/lp/bugs/model/tests/test_bugtask.py (+2/-0)
lib/lp/bugs/model/tests/test_bugtask_status.py (+1/-1)
lib/lp/bugs/scripts/tests/test_bugimport.py (+1/-1)
lib/lp/registry/model/distribution.py (+2/-2)
lib/lp/registry/model/distributionsourcepackage.py (+2/-2)
lib/lp/scripts/garbo.py (+41/-0)
lib/lp/scripts/tests/test_garbo.py (+37/-0)
lp:~bac/launchpad/bug-759467
- Graham Binns (community): Approve (code)
-
Diff: 1708 lines (+439/-234)24 files modifieddatabase/schema/security.cfg (+1/-0)
lib/canonical/config/schema-lazr.conf (+1/-1)
lib/canonical/database/enumcol.py (+30/-16)
lib/canonical/launchpad/doc/enumcol.txt (+39/-4)
lib/lp/bugs/browser/bugtask.py (+3/-52)
lib/lp/bugs/browser/tests/bugs-views.txt (+5/-4)
lib/lp/bugs/browser/tests/test_bugtask.py (+1/-2)
lib/lp/bugs/configure.zcml (+1/-0)
lib/lp/bugs/doc/bugtask.txt (+80/-56)
lib/lp/bugs/interfaces/bugsummary.py (+4/-4)
lib/lp/bugs/interfaces/bugtask.py (+24/-11)
lib/lp/bugs/model/bug.py (+10/-0)
lib/lp/bugs/model/bugsummary.py (+6/-2)
lib/lp/bugs/model/bugtarget.py (+4/-4)
lib/lp/bugs/model/bugtask.py (+80/-45)
lib/lp/bugs/model/tests/test_bugsummary.py (+3/-3)
lib/lp/bugs/model/tests/test_bugtask.py (+39/-8)
lib/lp/bugs/model/tests/test_bugtask_status.py (+11/-11)
lib/lp/bugs/scripts/tests/test_bugimport.py (+6/-2)
lib/lp/bugs/tests/test_bugtask_search.py (+6/-5)
lib/lp/registry/model/distribution.py (+2/-2)
lib/lp/registry/model/distributionsourcepackage.py (+2/-2)
lib/lp/scripts/garbo.py (+42/-0)
lib/lp/scripts/tests/test_garbo.py (+39/-0)
| Changed in launchpad: | |
| assignee: | nobody → Robert Collins (lifeless) |
Revision history for this message
| Brian Murray (brian-murray) wrote | #1 |
Revision history for this message
| Robert Collins (lifeless) wrote Re: [Bug 759467] Re: incomplete-with-response searches require complex searches | #2 |
| Changed in launchpad: | |
| assignee: | Robert Collins (lifeless) → Brad Crittenden (bac) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Is there a reason this didn't get landed?