support origin=any distroseries=natty in the review-stats call
Bug #757695 reported by
Michael Vogt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
Fix Released
|
Low
|
Michael Nelson |
Bug Description
Currntly the review-stats call lets me filter by origin and distroseries.
But I can't call "origin=any", "distroseries=
This means that the client will have to make a API call for each availalbe commercial-ppa that is available via
software-
will probably have even more soon. Would be nice to have just one API call to get all the stats for e.g. natty.
Cheers,
MIchael
Related branches
lp:~michael.nelson/rnr-server/757695-support-origin-any
- Ratings and Reviews Developers: Pending requested
-
Diff: 53 lines (+32/-0)2 files modifiedsrc/reviewsapp/api/handlers.py (+10/-0)
src/reviewsapp/tests/test_handlers.py (+22/-0)
tags: | added: kb-task sp-1 |
Changed in rnr-server: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
importance: | Undecided → Low |
Changed in rnr-server: | |
status: | New → Fix Committed |
Changed in rnr-server: | |
milestone: | none → 11.05 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Adding support to return stats across origins is trivial, but two related points:
1) We could return stats for the same package from different origins,
2) the resulting json does not (currently) contain any info to let you know which stat is for which origin (or distroseries, for that matter)
Is that OK, or do we also need to add origin or distroseries when origin or distroseries (respectively) is 'any' (or just include them always?)