[panel] circle of friends button icon missing

Bug #751325 reported by Florian Boucault
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
unity-2d
Fix Released
Critical
Florian Boucault

Bug Description

Unity uses the "start-here" icon from the theme and falls back on the "distributor-logo" icon if necessary

Related branches

Changed in unity-2d:
status: New → Confirmed
importance: Undecided → High
milestone: none → 3.8.2
Changed in unity-2d:
status: Confirmed → In Progress
Revision history for this message
Florian Boucault (fboucault) wrote :

In Unity, see src/PanelStyle.cpp:

GdkPixbuf *
PanelStyle::GetHomeButton ()
{
  GdkPixbuf *pixbuf = NULL;

  pixbuf = gtk_icon_theme_load_icon (gtk_icon_theme_get_default (),
                                     "start-here",
                                     24,
                                     (GtkIconLookupFlags)0,
                                     NULL);
  if (pixbuf == NULL)
    pixbuf = gtk_icon_theme_load_icon (gtk_icon_theme_get_default (),
                                       "distributor-logo",
                                       24,
                                       (GtkIconLookupFlags)0,
                                       NULL);
  return pixbuf;
}

description: updated
Changed in unity-2d:
assignee: nobody → Florian Boucault (fboucault)
Changed in unity-2d:
status: In Progress → Fix Committed
Changed in unity-2d:
status: Fix Committed → Fix Released
Revision history for this message
Bill Filler (bfiller) wrote :

This is broken with latest release. No circle of friends button shows up at all now which is not good. I believe it's because you need to load the default gtk theme in order to find the icons.

Changed in unity-2d:
status: Fix Released → Confirmed
importance: High → Critical
milestone: 3.8.2 → 3.10
summary: - [panel] circle of friends button icon needs to be updated to match
- Unity's
+ [panel] circle of friends button icon missing
Revision history for this message
Bill Filler (bfiller) wrote :

using unity-2d 3.8.2-0ubuntu1

Revision history for this message
Florian Boucault (fboucault) wrote :

Bill, it is broken not because of our code but because the fix for the SVGs files of the theme that we provided have not been merged. See https://bugs.launchpad.net/ubuntu/+source/ubuntu-mono/+bug/752607

Olivier recommended in our merge request: "I’m approving, but let’s wait for bug #752607 to be fixed before merging."
I decided on Friday to merge our code anyway hoping that the new SVGs would be uploaded to the theme the same Friday. I spoke to the responsible for that several times and we made it trivially easy for him to make that happen.

Let's make sure this happens first thing Monday morning.

Changed in unity-2d:
status: Confirmed → Fix Released
milestone: 3.10 → 3.8.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.