Scour

protect_ids options missing in scour.inkscape.py

Bug #747698 reported by jazzynico on 2011-04-01

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Scour	Fix Released	Medium	Unassigned

Bug Description

Hello,

I'm currently trying to update scour in Inkscape, and I run into an issue with the scour.inkscape.py file.
Apparently, some options (at least the three protect_ids ones, but maybe some others) are missing in this file, and thus using Inkscape's optimized SVG export doesn't work with the most recent scour version.

Could you please take a look so that I can commit the last revision in the Inkscape trunk?
Thanks.

Revision history for this message

Louis Simard (louis-simard-deactivatedaccount) wrote on 2011-04-02:

I've committed something to Scour trunk that attempts to fix this bug.

I'm aware of only the protect_ids_* options needing added, so I've added those to scour.inkscape.py and scour.inx.

Changed in scour:
assignee:	nobody → Louis Simard (louis-simard)
importance:	Undecided → Medium
status:	New → In Progress

Revision history for this message

Louis Simard (louis-simard-deactivatedaccount) wrote on 2011-04-02:

protect-ids-for-inkscape.patch Edit (3.5 KiB, text/plain)

Here's a patch you can use for quick testing.

Revision history for this message

jazzynico (jazzynico) wrote on 2011-04-02:

Fix confirmed, thanks Louis!

<off-topic>
With all the new parameters (compared to those in 0.48), the extension dialog is very high and just fits on my 1280x1024 screen. I think laptop (and netbooks) users can't even see the apply button at the bottom. The only solution I see for now is splitting the option et help tabs each in two. I suggest that we keep the most basic options in the first tabs and the advanced ones in the second. What do you think?
As for the help tab, improvements are currently discussed in the Inkscape dev list (http://old.nabble.com/proposal-to-enhance-the-python-extensions-td31264466.html)
</off-topic>