Ubuntu
oss4 package

package oss4-dkms 4.2-build2003-1ubuntu1 failed to install/upgrade: oss4 kernel module failed to build

Bug #746048 reported by Martin Erik Werner on 2011-03-30

288

This bug affects 34 people

	Status	Importance	Assigned to
oss4 (Debian)	Fix Released	Unknown	debbugs #595298
oss4 (Ubuntu)	Fix Released	Medium	Unassigned
Natty	Fix Released	Medium	Daniel van Vugt

Bug Description

IMPACT:

oss4-dkms 4.2-build2003-1ubuntu1 does not install successfully in Ubuntu 11.04. It appears it has never been able to with the natty kernel, because of this change to fs.h:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.36.y.git;a=commitdiff;h=b19dd42faf413b4705d4adb38521e82d73fa4249

FIX:

Used the patch from upstream:
http://opensound.hg.sourceforge.net/hgweb/opensound/opensound/rev/c63e54ba4988
which is already in oneiric (via v4.2-build2004).
The fix simply omits structure fields that no longer exist in kernel 2.6.36 and later.

TEST CASE:

1. sudo apt-get install oss4-dkms
2. Terminal output shows an error:
Error! Bad return status for module build on kernel: 2.6.38-8-generic (x86_64)
Consult the make.log in the build directory
/var/lib/dkms/oss4/4.2-build2003/build/ for more information.
* Unloading Open Sound System kernel modules: [ OK ]
* Starting Open Sound System: [fail]

REGRESSION POTENTIAL:

Minimal. It really can't be worse than never having worked at all in natty.

ProblemType: Package
DistroRelease: Ubuntu 11.04
Package: oss4-dkms 4.2-build2003-1ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-7.39-generic 2.6.38
Uname: Linux 2.6.38-7-generic x86_64
NonfreeKernelModules: nvidia
Architecture: amd64
DKMSBuildLog:
DKMS make.log for oss4-4.2-build2003 for kernel 2.6.38-7-generic (x86_64)
Wed Mar 30 22:05:56 BST 2011
Date: Wed Mar 30 22:06:02 2011
ErrorMessage: oss4 kernel module failed to build
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha amd64 (20110312)
PackageVersion: 4.2-build2003-1ubuntu1
SourcePackage: oss4
Title: package oss4-dkms 4.2-build2003-1ubuntu1 failed to install/upgrade: oss4 kernel module failed to build
UpgradeStatus: No upgrade log present (probably fresh install)

See original description

Tags:

Related branches

lp:~vanvugt/ubuntu/natty/oss4/fix-746048

Merged into lp:ubuntu/natty/oss4

Marc Deslauriers: Pending requested 2011-06-17

Stefano Rivera: Pending requested 2011-06-17

Ubuntu branches: Pending requested 2011-06-17

lp:ubuntu/oneiric/oss4

lp:ubuntu/natty-proposed/oss4

Revision history for this message

Martin Erik Werner (arand) wrote on 2011-03-30:

Dependencies.txt Edit (1.0 KiB, text/plain; charset="utf-8")

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2011-06-02:

Here is the error on natty:

cp /lib/modules/2.6.38-8-generic/build/include/linux/limits.h /var/lib/dkms/oss4/4.2-build2003/build/core && make -C /lib/modules/2.6.38-8-generic/build SUBDIRS=/var/lib/dkms/oss4/4.2-build2003/build/core modules && make -C /var/lib/dkms/oss4/4.2-build2003/build/drivers osscore_symbols.inc && make -C /lib/modules/2.6.38-8-generic/build SUBDIRS=/var/lib/dkms/oss4/4.2-build2003/build/drivers modules >> /var/lib/dkms/oss4/4.2-build2003/build/make.log 2>&1
make: entrant dans le répertoire « /usr/src/linux-headers-2.6.38-8-generic »
CC [M] /var/lib/dkms/oss4/4.2-build2003/build/core/oss_core.o
/var/lib/dkms/oss4/4.2-build2003/build/core/oss_core.c: In function ‘alloc_fop’:
/var/lib/dkms/oss4/4.2-build2003/build/core/oss_core.c:956:6: error: ‘struct file_operations’ has no member named ‘ioctl’
/var/lib/dkms/oss4/4.2-build2003/build/core/oss_core.c:960:14: warning: assignment from incompatible pointer type
/var/lib/dkms/oss4/4.2-build2003/build/core/oss_core.c: In function ‘oss_pci_read_devpath’:
/var/lib/dkms/oss4/4.2-build2003/build/core/oss_core.c:1634:3: warning: return discards qualifiers from pointer target type
make[1]: *** [/var/lib/dkms/oss4/4.2-build2003/build/core/oss_core.o] Erreur 1
make: *** [_module_/var/lib/dkms/oss4/4.2-build2003/build/core] Erreur 2
make: quittant le répertoire « /usr/src/linux-headers-2.6.38-8-generic »
(bad exit status: 2)

Changed in oss4 (Ubuntu):
importance:	Undecided → High
status:	New → Triaged

Torin Ireland (coldnitro) on 2011-06-04

Changed in oss4 (Ubuntu):
status:	Triaged → Confirmed
assignee:	nobody → Torin Ireland (coldnitro)
assignee:	Torin Ireland (coldnitro) → nobody

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2011-06-14:

The error "error: ‘struct file_operations’ has no member named ‘ioctl’" is due to the removal of the ioctl member in kernel 2.6.36 and later.:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.36.y.git;a=commitdiff;h=b19dd42faf413b4705d4adb38521e82d73fa4249

Uses of the ioctl member should be removed and replaced with unlocked_ioctl/compat_ioctl members, AFAIK...

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2011-06-14:

The fix for this bug is in oss4 v4.2-2004:
http://opensound.hg.sourceforge.net/hgweb/opensound/opensound/rev/c63e54ba4988

Thanks to andre who pointed this out in bug 709740.

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2011-06-14:

A simpler way to verify where the build is failing, since make.log seems to be empty, is to just run:
sudo make -C /lib/modules/`uname -r`/build SUBDIRS=/var/lib/dkms/oss4/4.2-build2003/build/core modules

This gives the same error as Jean-Baptiste Lallement shows.

Daniel van Vugt (vanvugt) on 2011-06-14

description:

updated

Bug Watch Updater (bug-watch-updater) on 2011-06-14

Changed in oss4 (Debian):
status:	Unknown → New

Daniel van Vugt (vanvugt) on 2011-06-14

Changed in oss4 (Ubuntu):
assignee:	nobody → Daniel van Vugt (vanvugt)
status:	Confirmed → In Progress

Daniel van Vugt (vanvugt) on 2011-06-16

description:

updated

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-06-16:

This bug was fixed in the package oss4 - 4.2-build2004-1ubuntu1

---------------
oss4 (4.2-build2004-1ubuntu1) oneiric; urgency=low

  * Merge from Debian unstable.
    - Supports our current kernel (LP: #746048)
    Remaining changes:
    - debian/oss4-dkms.dkms.in: s/source/build/ in Kernel headers paths.
  * ld-as-needed.patch: Re-order CC arguments to enable building with ld
    --as-needed (LP: #770972)

oss4 (4.2-build2004-1) unstable; urgency=low

  [ Samuel Thibault ]
  * debian/control: Add liboss4-salsa2, liboss4-salsa-dev and
    liboss4-salsa-asound2 packages, equivalent to (and will replace) those from
    the oss-libsalsa package (Closes: #589127).
  * debian/patches/liboss4-salsa.patch: New patch to rename libsalsa into
    liboss4-salsa to avoid conflicts in the archive for no good reason.
  * debian/rules: Make in libOSSlib and libsalsa.
  * debian/liboss4-salsa-dev.install, debian/liboss4-salsa2.install,
    debian/liboss4-salsa-asound2.links, debian/liboss4-salsa-dev.links:
    Install liboss4-salsa libraries like was done in the oss-libsalsa package.
  * include-alsa: Add a copy of ALSA 1.0.5 headers: Cf ALSA_1.0.* symbols in
    libsalsa, this is the roughly supported version.
  * debian/copyright: Update for new include-alsa files.
  * alsa.pc: New file for compatibility with libasound-dev.
  * debian/control:
    - Add Vcs-Browser and Vcs-Svn fields.
    - Use linux-any instead of the list of Linux archs (Closes: #604679).
    - Make dkms dependency linux-any only.
  * debian/patches/hurd_iot.patch: New patch to fix soundcard.h usage in
    libsalsa on hurd-i386.
  * debian/patches/libsalsa_fixes.patch: New patch to fix some printf usages
    and ioctl declaration in libsalsa.
  * debian/patches/no_EBADE.patch: New patch to cope with hurd-i386 not having
    EBADE.
  * debian/patches/CFLAGS.patch: New patch to make oss4 take debian/rules
    CFLAGS into account.
  * debian/patches/snd_asoundlib_version.patch: New patch to add
    snd_asoundlib_version().
  * debian/patches/generic_srccconf.patch: New patch to fix source
    configuration on unknown archs.

  [ Romain Beauxis ]
  * Fixed README.Debian to only mention dkms' modules.
  * Switch to dpkg-source 3.0 (quilt) format
  * Added DM-Upload-Allowed: yes

  [ Sebastien NOEL ]
  * New upstream release (Closes: #595298, #619272).
  * Fix typo in initscript (Closes: #627149).
  * debian/control: adjust linux-headers dependencies (Closes: #628879).
-- Stefano Rivera <email address hidden> Thu, 16 Jun 2011 20:37:48 +0200

This bug was fixed in the package oss4 - 4.2-build2004-1ubuntu1

---------------
oss4 (4.2-build2004-1ubuntu1) oneiric; urgency=low

oss4 (4.2-build2004-1) unstable; urgency=low

[ Romain Beauxis ]
  * Fixed README.Debian to only mention dkms' modules.
  * Switch to dpkg-source 3.0 (quilt) format
  * Added DM-Upload-Allowed: yes

[ Sebastien NOEL ]
  * New upstream release (Closes: #595298, #619272).
  * Fix typo in initscript (Closes: #627149).
  * debian/control: adjust linux-headers dependencies (Closes: #628879).
 -- Stefano Rivera <stefanor@ubuntu.com>   Thu, 16 Jun 2011 20:37:48 +0200

Changed in oss4 (Ubuntu):
status:	In Progress → Fix Released

Stefano Rivera (stefanor) on 2011-06-16

Changed in oss4 (Ubuntu Natty):
assignee:	nobody → Daniel van Vugt (vanvugt)
importance:	Undecided → Medium
status:	New → In Progress
Changed in oss4 (Ubuntu):
assignee:	Daniel van Vugt (vanvugt) → nobody
importance:	High → Medium

Daniel van Vugt (vanvugt) on 2011-06-17

description:

updated

Revision history for this message

Stefano Rivera (stefanor) wrote on 2011-06-17:

Uploaded to natty-proposed, pending SRU team review.

Changed in oss4 (Ubuntu Natty):
status:	In Progress → Fix Committed

Revision history for this message

Martin Pitt (pitti) wrote on 2011-06-18: Please test proposed package

Accepted oss4 into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags:

added: verification-needed

Revision history for this message

Michal Suchanek (hramrach) wrote on 2011-06-18: Re: [Bug 746048] Re: package oss4-dkms 4.2-build2003-1ubuntu1 failed to install/upgrade: oss4 kernel module failed to build

On 18 June 2011 12:16, Martin Pitt <email address hidden> wrote:
> Accepted oss4 into natty-proposed, the package will build now and be
> available in a few hours. Please test and give feedback here. See
> https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
> enable and use -proposed. Thank you in advance!
>

Works for me with the package from Oneiric.

Thanks

Michal

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2011-06-20:

#10

The package from oneiric is not the one to be testing for natty. The natty packages are:
oss4-base_4.2-build2003-1ubuntu1.11.04.1_*
in: http://archive.ubuntu.com/ubuntu/pool/universe/o/oss4/

I can confirm the proposed packages solve the problem on amd64 natty:
oss4-base_4.2-build2003-1ubuntu1.11.04.1_amd64.deb
oss4-dkms_4.2-build2003-1ubuntu1.11.04.1_all.deb

Martin Pitt (pitti) on 2011-06-20

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-06-27:

#11

This bug was fixed in the package oss4 - 4.2-build2003-1ubuntu1.11.04.1

---------------
oss4 (4.2-build2003-1ubuntu1.11.04.1) natty-proposed; urgency=low

* Fixed DKMS build failure on kernels >= 2.6.36, ie. oss4-dkms never
successfully installed on natty until now (LP: #746048)
-- Daniel van Vugt <email address hidden> Wed, 15 Jun 2011 14:00:38 +0800

Changed in oss4 (Ubuntu Natty):
status:	Fix Committed → Fix Released

Bug Watch Updater (bug-watch-updater) on 2011-08-10

Changed in oss4 (Debian):
status:	New → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #709740
Bug #749333
Bug #772633
Bug #773226
Bug #773906
Bug #773927
Bug #773982
Bug #774108
Bug #774209
Bug #775082
Bug #775106
Bug #775908
Bug #776313
Bug #777942
Bug #778162
Bug #782343
Bug #786772
Bug #787291
Bug #787771
Bug #789132
Bug #789597
Bug #790996
Bug #792756
Bug #793596
Bug #795876
Bug #796126
Bug #796137
Bug #797027
Bug #797717
Bug #798491
Bug #801250
Bug #801903
Bug #889633

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Dependencies.txt Edit

Add attachment

Remote bug watches

debbugs #595298
[done grave sid wheezy] Edit

Bug watches keep track of this bug in other bug trackers.

Ubuntuoss4 package

package oss4-dkms 4.2-build2003-1ubuntu1 failed to install/upgrade: oss4 kernel module failed to build

Bug Description

Related branches

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
oss4 package