qlog shows hidden context menu

Screenshot

I posted this bug to bzr project by mistake. Please move it to qbzr.

I've seen this problem before, I think if you "move" the mouse while the "hidden context menu" is shown, it "becomes" visible.

Craig Hewetson пишет:
> I've seen this problem before, I think if you "move" the mouse while the
> "hidden context menu" is shown, it "becomes" visible.

Maybe we don't repaint simnething while we should, or maybe it's a Qt
bug (and I won't be surprised).

--
All the dude wanted was his rug back

Steps to reproduce it are even simpler:

1. bzr qlog
2. "Update to this revision" and this bug appears.

Tried to move mouse while the menu is shown and it didn't help. This "hidden menu" works: if I click in the area of menu's shadow border, the corresponding item is executed.

Context menu in the changed files list renders correctly.

I can't reproduce this bug on my Windows XP with bzr-2.3.1 installed. All I can see that context menu appears "empty" every time for about 1 second or slightly more, after that it's painted correctly. This is with or without using "Update to revision" action.

As I can say, qlog creates a list of items for context menu in the run-time for every right-click, because that menu is dynamic. Can you show me the relevant part of .bzr.log? I don't think the creation of context menu items has bugs, I think in this case you should get and error box with traceback. It seems for me like Qt don't want to repaint menu for some reason.

Please say what is your OS version and platform (32/64 bits)?

Windows 7 Professional 64 bit

.bzr.log:

this is a debug log for diagnosing/reporting problems in bzr
you can delete or truncate this file, or include sections in
bug reports to https://bugs.launchpad.net/bzr/+filebug

.bzr.log:

Tue 2011-03-29 20:46:29 +0400
0.037 bazaar version: 2.3.1
0.037 bzr arguments: [u'qlog']
0.055 looking for plugins in C:/Users/Halega/AppData/Roaming/bazaar/2.0/plugins
0.056 looking for plugins in C:/Program Files (x86)/Bazaar/plugins
0.161 encoding stdout as sys.stdout encoding 'cp866'
0.342 opening working tree 'D:/sk/work/backoffice/work'

Tue 2011-03-29 20:46:33 +0400
0.039 bazaar version: 2.3.1
0.039 bzr arguments: [u'qsubprocess', u'--bencode', u'l6:update2:-r55:revid:<email address hidden>']
0.058 looking for plugins in C:/Users/Halega/AppData/Roaming/bazaar/2.0/plugins
0.058 looking for plugins in C:/Program Files (x86)/Bazaar/plugins
0.166 encoding stdout as osutils.get_user_encoding() 'cp1251'
0.228 bazaar version: 2.3.1
0.228 bzr arguments: [u'update', u'-r', u'revid:<email address hidden>']
0.229 Returning RevisionSpec RevisionSpec_revid for revid:<email address hidden>
0.230 encoding stdout as osutils.get_user_encoding() 'cp1251'
0.247 opening working tree 'D:/sk/work/backoffice/work'
[ 2884] 2011-03-29 20:46:34.167 INFO: M VBK/Vec.Core.Services/PriceListRawService.cs
[ 2884] 2011-03-29 20:46:34.173 INFO: All changes applied successfully.
[ 2884] 2011-03-29 20:46:34.332 INFO: Updated to revision 1128 of branch D:/sk/work/backoffice/work
0.702 Transferred: 0kB (0.0kB/s r:0kB w:0kB)
0.702 Transferred: 0kB (0.0kB/s r:0kB w:0kB)
0.702 return code 0
11.255 Transferred: 0kB (0.0kB/s r:0kB w:0kB)
11.255 return code 0

Short video (flv) demonstrates the bug.

On 30/03/2011 10:26, Stanislav Kalashnikov wrote:
> Short video (flv) demonstrates the bug.

Interesting that it only starts happened after a context menu action was
selected.

Am I understand correctly that red circle appears on left click, and blue circle appears on right click?

Can you test if this bug can be reproduced with left click to select the revision and then using context menu button on the keyboard (between right Alt and Ctrl)?

> Am I understand correctly that red circle appears on left click, and blue circle appears on right click?

That's correct. But blue circle appears not on every right mouse click in video: I thinks it is because of conversion/compression (right clicks are fast, and frames with blue circles were dropped from video during avi-to-flv conversion).

> Can you test if this bug can be reproduced with left click to select the revision and then using context menu button on the keyboard (between right Alt and Ctrl)?

Keyboard's context menu button shows just the same "hidden" menu as right mouse click.

I made some tests on different versions of bzr and qbzr:

Bazaar (bzr) 2.2.3
 - qbzr 0.19.2 - OK (menu is shown correct)
 - qbzr 0.19.3 - OK
 - qbzr 0.20.0 - BUG

Bazaar (bzr) 2.3.1
 - qbzr 0.20.0 - BUG

Bazaar (bzr) 2.4b1
 - qbzr 0.21.0dev - BUG

And one more note. It happens only when the "Update to this revision" menu item is activated. If I select "Revert to this revision", "Reverse Cherry pick", "Tag revision...", etc menu works correctly.

Stanislav Kalashnikov пишет:
> And one more note. It happens only when the "Update to this revision"
> menu item is activated. If I select "Revert to this revision", "Reverse
> Cherry pick", "Tag revision...", etc menu works correctly.

One more thing you can test: do `bzr update -r-3` for example in the
console and then open qlog and try context menu. Will it work as
expected or will bug anyway?

--
All the dude wanted was his rug back

> One more thing you can test: do `bzr update -r-3` for example in the console and then open qlog and try context menu. Will it work as expected or will bug anyway?

Works correctly, as expected. (Attached .bzr.log)

On 30/03/2011 12:27, Stanislav Kalashnikov wrote:
> I made some tests on different versions of bzr and qbzr:
>
> Bazaar (bzr) 2.2.3
> - qbzr 0.19.2 - OK (menu is shown correct)
> - qbzr 0.19.3 - OK
> - qbzr 0.20.0 - BUG
>
> Bazaar (bzr) 2.3.1
> - qbzr 0.20.0 - BUG
>
> Bazaar (bzr) 2.4b1
> - qbzr 0.21.0dev - BUG

Thank you. That is very informative.

On 30/03/2011 12:43, Stanislav Kalashnikov wrote:
> And one more note. It happens only when the "Update to this revision"
> menu item is activated. If I select "Revert to this revision", "Reverse
> Cherry pick", "Tag revision...", etc menu works correctly.

Hmm, "Update to this revision" is the only one that does a graph
refresh. I assume that you will see the bug after pressing the refresh
button.

>
> Hmm, "Update to this revision" is the only one that does a graph
> refresh. I assume that you will see the bug after pressing the refresh
> button.

Yes, it's true. After refreshing menu disappears too.

I've tried this on Vista 32-bit, and I still cannot reproduce.
Maybe (maybe) it's somehow related to 64-bit Windows, or to Windows 7.
For me it works fine on both Windows XP 32-bit, Windows Vista 32-bit.

Tested on Windows 7 32-bit in VirtualBox and there's the bug too.

I made some more detailed tests revision by revision and I think I found one where bug was introduced:
1289.1.2 revid:<email address hidden> qlog: Refactor so that :

1289.1.1 revid:<email address hidden> is the last revision where menu works correctly.

Tests were made on bzr 2.3.1.

Stanislav Kalashnikov пишет:
> Tested on Windows 7 32-bit in VirtualBox and there's the bug too.
>
> I made some more detailed tests revision by revision and I think I found one where bug was introduced:
> 1289.1.2 revid:<email address hidden> qlog: Refactor so that :
>
> 1289.1.1 revid:<email address hidden> is the
> last revision where menu works correctly.
>
> Tests were made on bzr 2.3.1.
>
Thank you very much!

--
All the dude wanted was his rug back

This problem is reproduced in my environment.

Bazaar (bzr) 2.4b3
  Python interpreter: C:\DEVELOP\py_envs\bzr2.4\Scripts\python.exe 2.6.6
  Python standard library: C:\DEVELOP\py_envs\bzr2.4\lib
  Platform: Windows-7-6.1.7600
  bzrlib: C:\DEVELOP\py_envs\bzr2.4\lib\site-packages\bzrlib
  Bazaar configuration: C:\Users\iwata\AppData\Roaming\bazaar\2.0
  Bazaar log file: C:\Users\iwata\Documents\.bzr.log

And this patch will fix it (at least in my environment)

I can not reproduce on Linux with Bazaar (bzr) 2.5.0dev1 and qbzr trunk

@Hidetaka: could you convert your patch into merge proposal please?

I've created merge proposal against lp:qbzr
May I also do againgst lp:qbzr/0.21 ?

2011/8/5 Alexander Belchenko <email address hidden>:
> @Hidetaka: could you convert your patch into merge proposal please?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/744904
>
> Title:
>  qlog shows hidden context menu
>
> Status in Qt frontend for Bazaar:
>  Confirmed
>
> Bug description:
>  It's reproducible bug:
>
>  1. Execute bzr qbrowse
>  2. Select a file with some history and select "Show log" by right mouse click.
>  3. Pick a random revision in a history and select "Update to this revision".
>  4. Next right clicks in qlog window show hidden context menu: http://i.imgur.com/v96XH.png (link to a screenshot).
>
>  Bazaar (bzr) 2.3.1
>    Python interpreter: C:\Program Files (x86)\Bazaar\python26.dll 2.6.6
>    Python standard library: C:\Program Files (x86)\Bazaar\lib\library.zip
>    Platform: Windows-7-6.1.7601-SP1
>    bzrlib: C:\Program Files (x86)\Bazaar\lib\library.zip\bzrlib
>    Bazaar configuration: C:\Users\sk\AppData\Roaming\bazaar\2.0
>    Bazaar log file: C:\Users\sk\Documents\.bzr.log
>
>  bzrtools 2.3.1
>     Various useful commands for working with bzr.
>
>  colo 0.2.1
>     Work with colocated branches using current technology.
>
>  explorer 1.1.2
>     Version Control for Human Beings.
>
>  fastimport 0.10.0
>     FastImport Plugin
>
>  launchpad 2.3.1
>     Launchpad.net integration plugin for Bazaar.
>
>  loom 2.2.1dev
>     Loom is a bzr plugin which adds new commands to manage a loom of patches.
>
>  netrc_credential_store 2.3.1
>     Use ~/.netrc as a credential store for authentication.conf.
>
>  news_merge 2.3.1
>     Merge hook for bzr's NEWS file.
>
>  pipeline 1.1.0
>     Manage a series of branches as a pipeline.
>
>  qbzr 0.20.0
>     QBzr - Qt-based frontend for Bazaar
>
>  rewrite 0.6.2dev
>     Rebase support.
>
>  svn 1.0.5dev
>     Support for Subversion branches
>
>  upload 1.0.0
>     Upload a working tree, incrementally.
>
>  xmloutput 0.8.7.dev
>     This plugin adds an option (--xml) to log and provides an xml version of some builtin commands.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qbzr/+bug/744904/+subscriptions
>

05.08.2011 2:51, IWATA Hidetaka пишет:
> I've created merge proposal against lp:qbzr
> May I also do againgst lp:qbzr/0.21 ?

Usually in such situations it's better to create MP against
stable/supported release first, that way it's much easier to merge it
to all applicable series. As this bug has been reported against qbzr
0.20 I think we can target 0.20 as the base series and then merge the
fix all way up to trunk.

OK.

I'll move this fix onto release-0.20 and resubmit MP.
2011/08/05 12:41 "Alexander Belchenko" <email address hidden>:
> 05.08.2011 2:51, IWATA Hidetaka пишет:
>> I've created merge proposal against lp:qbzr
>> May I also do againgst lp:qbzr/0.21 ?
>
> Usually in such situations it's better to create MP against
> stable/supported release first, that way it's much easier to merge it
> to all applicable series. As this bug has been reported against qbzr
> 0.20 I think we can target 0.20 as the base series and then merge the
> fix all way up to trunk.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/744904
>
> Title:
> qlog shows hidden context menu
>
> Status in Qt frontend for Bazaar:
> Confirmed
>
> Bug description:
> It's reproducible bug:
>
> 1. Execute bzr qbrowse
> 2. Select a file with some history and select "Show log" by right mouse
click.
> 3. Pick a random revision in a history and select "Update to this
revision".
> 4. Next right clicks in qlog window show hidden context menu:
http://i.imgur.com/v96XH.png (link to a screenshot).
>
> Bazaar (bzr) 2.3.1
> Python interpreter: C:\Program Files (x86)\Bazaar\python26.dll 2.6.6
> Python standard library: C:\Program Files (x86)\Bazaar\lib\library.zip
> Platform: Windows-7-6.1.7601-SP1
> bzrlib: C:\Program Files (x86)\Bazaar\lib\library.zip\bzrlib
> Bazaar configuration: C:\Users\sk\AppData\Roaming\bazaar\2.0
> Bazaar log file: C:\Users\sk\Documents\.bzr.log
>
> bzrtools 2.3.1
> Various useful commands for working with bzr.
>
> colo 0.2.1
> Work with colocated branches using current technology.
>
> explorer 1.1.2
> Version Control for Human Beings.
>
> fastimport 0.10.0
> FastImport Plugin
>
> launchpad 2.3.1
> Launchpad.net integration plugin for Bazaar.
>
> loom 2.2.1dev
> Loom is a bzr plugin which adds new commands to manage a loom of patches.
>
> netrc_credential_store 2.3.1
> Use ~/.netrc as a credential store for authentication.conf.
>
> news_merge 2.3.1
> Merge hook for bzr's NEWS file.
>
> pipeline 1.1.0
> Manage a series of branches as a pipeline.
>
> qbzr 0.20.0
> QBzr - Qt-based frontend for Bazaar
>
> rewrite 0.6.2dev
> Rebase support.
>
> svn 1.0.5dev
> Support for Subversion branches
>
> upload 1.0.0
> Upload a working tree, incrementally.
>
> xmloutput 0.8.7.dev
> This plugin adds an option (--xml) to log and provides an xml version of
some builtin commands.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qbzr/+bug/744904/+subscriptions