Ubuntu
gnome-orca package

[Natty] one desktop environment announce message is wrong marked for translation for src/orca/scripts/default.py file

Bug #744875 reported by Attila Hammer on 2011-03-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gnome-orca (Ubuntu)	Fix Released	Undecided	Luke Yelavich

Bug Description

Binary package hint: gnome-orca

Dear Developers,

If I press Orca Modifier+e keystroke, Orca spokening untranslated the current desktop environment.
Of course, upstream level and Launchpad gnome-orca package is full translated with hungarian language, the translation is 100%.
The problem happening because src/orca/scripts/default.py file the %s style message is wrong marked for translation.

I attaching two patch:
1. A patch with fix this problem direct with src/orca/scripts/default.py file.
2. And attaching debian/patches/07 beginning patch name, this is the original putted Luke doed patch, but fixed the problematic message translation markup the %s style desktop environment announce message.

I tested my src/orca/scripts/default.py file fix patch. After I rebuilded gnome-orca 2.92 package and install the new package, Orca wonderful spokening hungarian language the current desktop environment if I press Orca modifier+e keystroke.

Attila

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: gnome-orca 2.91.92-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-7.39-generic 2.6.38
Uname: Linux 2.6.38-7-generic i686
Architecture: i386
Date: Tue Mar 29 12:24:28 2011
LiveMediaBuild: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110327)
ProcEnviron:
LANGUAGE=hu_HU:en
LANG=hu_HU.UTF-8
SHELL=/bin/bash
SourcePackage: gnome-orca
UpgradeStatus: No upgrade log present (probably fresh install)

Tags:

Related branches

lp:ubuntu/oneiric/gnome-orca

Revision history for this message

Attila Hammer (hammera) wrote on 2011-03-29:

Dependencies.txt Edit (6.3 KiB, text/plain; charset="utf-8")

This patch fix the wrong message translation markup for src/orca/scripts/default.py filename. Edit (929 bytes, text/plain)

Revision history for this message

Attila Hammer (hammera) wrote on 2011-03-29:

Complete patch with equals Luke already doed patch, but I only fixed the wrong translation markup %s message Edit (4.7 KiB, text/plain)

Luke Yelavich (themuso) on 2011-03-29

Changed in gnome-orca (Ubuntu):
assignee:	nobody → Luke Yelavich (themuso)
status:	New → Triaged

Revision history for this message

Attila Hammer (hammera) wrote on 2011-03-30: Re: [Bug 744875] Re: [Natty] one desktop environment announce message is wrong marked for translation for src/orca/scripts/default.py file

Hy Luke,

You answered me in Ubuntu Accessibility list I need using the diff -u
argument when need generating a diff file, because unified diff files is
easyest readable.
I need generating again the patches, or now the attached patches are
will be good when you uploading new upstream release? I now using diff
-p argument with patch generation, for example:
diff -p src/orca/scripts/default.py.old src/orca/scripts/default.py
>patch_name

If need the patch regeneration, in debian/patches prewious already have
a 07_orca_desktop_environment.patch named patch file, with implementing
the desktop environment announcement feature. Before I generating
unified diff file, need fixing only the wrong marked translation message
with this patch file, or need both two places fixing the wrong message
(debian/patches/07_orca_desktop_environment.patch and already original
patch patched src/orca/scripts/default.py file)?
What the standard way this situation if a function implementation fix
only applied with Ubuntu specific package?

I ask this, because prewious I sent patches only upstream level for
Orca, this situation when I changing anything with source code, git diff
generated prewious proper patches, independent how many source files is
changed.

Attila

Revision history for this message

Luke Yelavich (themuso) wrote on 2011-03-30:

On Wed, Mar 30, 2011 at 04:28:10PM EST, Attila Hammer wrote:
> Hy Luke,
>
> You answered me in Ubuntu Accessibility list I need using the diff -u
> argument when need generating a diff file, because unified diff files is
> easyest readable.
> I need generating again the patches, or now the attached patches are
> will be good when you uploading new upstream release? I now using diff
> -p argument with patch generation, for example:
> diff -p src/orca/scripts/default.py.old src/orca/scripts/default.py
> >patch_name

Don't worry about attaching fixed patches to this bug, I am happy to work with what you have attached already.

Thanks.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-03-31:

This bug was fixed in the package gnome-orca - 2.91.93-0ubuntu1

---------------
gnome-orca (2.91.93-0ubuntu1) natty; urgency=low

  * New upstream release
    - GNOME 3.0:
      + Use gsettings -- and not gconf -- to determine if accessibility is
        enabled (Thanks Frederic!)
      + Fix for bug #640134 - Catch pyatspi2's RuntimeErrors
    - General:
      + Fix for the problem of punctuation settings not getting properly
        loaded or unloaded when the application script changes
      + Fix for the problem of voice settings not getting properly loaded
        or unloaded when the application script changes
      + Voice settings need to be ACSSs; not dicts
  * debian/patches/07_orca_desktop_environment.patch: Fix syntax to properly
    allow for translation, thanks to Attila Hammer for the patch (LP: #744875)
  * debian/patches/04_use_gconf.patch: Use gconf to check whether
    accessibility is enabled. This reverts upstream commit
    7716a24 in the gnome-3-0 orca git branch
  * debian/patches/05_orca_sudo_gconf.patch: Renamed to allow the above gconf
    patch to be applied first
-- Luke Yelavich <email address hidden> Fri, 01 Apr 2011 09:20:50 +1100