Launchpad itself

The change bug watch page tricks people into entering URLs

Bug #74428 reported by Christian Reis
24
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Eleanor Berger

Bug Description

I noticed the following error in the Bugzilla watch updater logs:

12:42:34 WARNING Invalid bug u'http://bugzilla.kernel.org/show_bug.cgi?id=7185' on http://bugzilla.kernel.org (local bugs: 65999)

I went to change it:

https://launchpad.net/products/launchpad/+bug/65999/watches/29659

And the box contained a URL. I think that because we tell people to enter URLs for remote watches, people editing watches think they only need to enter the URL as well. So either we parse input of that field through the URL-defier, or we validate it, or we allow people to replace an existing bug watch with another based on URL. I kinda like that third option, even though it would make my life as a gardener harder.

Revision history for this message
Björn Tillenius (bjornt) wrote :

Yeah, I think that page should prompt for an URL, not a bugtracker and bug id.

Changed in malone:
assignee: nobody → bjornt
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Revision history for this message
Diogo Matsubara (matsubara) wrote :

The bug watch form in the bugtask edit form (e.g. http://bugs.launchpad.dev/debian/+source/mozilla-firefox/+bug/1/+editstatus) and the bugwatch edit page (e.g. http://bugs.launchpad.dev/bugs/1/+watch/5) should be fixed together.

Björn Tillenius (bjornt)
Changed in malone:
assignee: bjornt → nobody
Christian Reis (kiko)
Changed in malone:
assignee: nobody → intellectronica
milestone: 1.1.12 → 1.2.1
Revision history for this message
Eleanor Berger (intellectronica) wrote :

The only problem with this is if the user enters a URL for a a bug tracker we don't recognize. Should we just reject it with an error message, or go the route of creating a new bug tracker as we do in comments?

I favour the first option, and perhaps even rejecting if the bug tracker is different than the one already recorded.

Eleanor Berger (intellectronica)
Changed in malone:
status: Confirmed → In Progress
Revision history for this message
Christian Reis (kiko) wrote :

Just reject it with an error message in both situations; this is not a very common situation.

Revision history for this message
Eleanor Berger (intellectronica) wrote :

RF 5449

Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Eleanor Berger (intellectronica) wrote :

After some discussion it was decided to change the bugtask editstatus form too, and to make the URL entry control wider

Changed in malone:
status: Fix Committed → In Progress
Revision history for this message
Eleanor Berger (intellectronica) wrote :

RF 5484

Changed in malone:
status: In Progress → Fix Committed
Eleanor Berger (intellectronica)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.