OpenStack Compute (nova)

No XML namespace in OpenStack API

Bug #740576 reported by justinsb
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
justinsb
OpenStack Compute (nova) 2011.3 "diablo"

Bug Description

The OpenStack API, when returning XML, do not specify the namespace.

Validation against the schema therefore fails immediately.

Related branches

lp:~justin-fathomdb/nova/bug740576
Brian Lamar (community): Approve
Vish Ishaya (community): Approve
Brian Waldon (community): Approve
Soren Hansen (community): Approve
termie (community): Needs Fixing
Diff: 702 lines (+165/-53)
21 files modified
nova/api/direct.py (+5/-1)
nova/api/openstack/accounts.py (+2/-3)
nova/api/openstack/backup_schedules.py (+2/-2)
nova/api/openstack/common.py (+11/-0)
nova/api/openstack/consoles.py (+2/-2)
nova/api/openstack/extensions.py (+6/-4)
nova/api/openstack/faults.py (+3/-2)
nova/api/openstack/flavors.py (+5/-2)
nova/api/openstack/image_metadata.py (+2/-1)
nova/api/openstack/images.py (+4/-4)
nova/api/openstack/limits.py (+2/-2)
nova/api/openstack/server_metadata.py (+2/-1)
nova/api/openstack/servers.py (+4/-1)
nova/api/openstack/shared_ip_groups.py (+2/-2)
nova/api/openstack/users.py (+1/-2)
nova/api/openstack/zones.py (+2/-4)
nova/tests/api/openstack/test_faults.py (+5/-4)
nova/tests/api/openstack/test_images.py (+13/-6)
nova/tests/api/openstack/test_limits.py (+13/-5)
nova/tests/integrated/test_xml.py (+56/-0)
nova/wsgi.py (+23/-5)
lp:~justin-fathomdb/nova/add-xsd
Jay Pipes (community): Approve
Soren Hansen (community): Abstain
Brian Lamar (community): Disapprove
Devin Carlen (community): Approve
termie (community): Approve
Thierry Carrez (community): Approve (ffe)
Vish Ishaya: Pending (ptl) requested
Diff: 3420 lines (+3363/-0)
11 files modified
nova/api/openstack/schemas/v1.0/xsd/actions.xsd (+256/-0)
nova/api/openstack/schemas/v1.0/xsd/backup.xsd (+374/-0)
nova/api/openstack/schemas/v1.0/xsd/common.xsd (+51/-0)
nova/api/openstack/schemas/v1.0/xsd/faults.xsd (+480/-0)
nova/api/openstack/schemas/v1.0/xsd/flavor.xsd (+144/-0)
nova/api/openstack/schemas/v1.0/xsd/image.xsd (+263/-0)
nova/api/openstack/schemas/v1.0/xsd/ipgroup.xsd (+215/-0)
nova/api/openstack/schemas/v1.0/xsd/limits.xsd (+354/-0)
nova/api/openstack/schemas/v1.0/xsd/rackspace.xsd (+141/-0)
nova/api/openstack/schemas/v1.0/xsd/server.xsd (+913/-0)
nova/api/openstack/schemas/v1.0/xsd/version.xsd (+172/-0)
justinsb (justin-fathomdb)
Changed in nova:
assignee: nobody → justinsb (justin-fathomdb)
Revision history for this message
Thierry Carrez (ttx) wrote :

Please only link branches that are actually fixing the bug, since our tools use the link to assess priority. I removed the "related" ones.

Changed in nova:
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
justinsb (justin-fathomdb) wrote :

ttx: I wish you hadn't unlinked the branches.. The priority of those related branches should also be boosted, because those branches are doing testing of this issue. It's also confusing because those branches are no longer linked to this issue, so it's difficult to know what those branches are about.

Branches:
bug740576 fixes the immediate problem, and has minimal unit testing
add-xsd includes the spec that we want to follow
java-api is a binding that works off the spec
"future-branch" will actually use that binding to test this properly

LP calls them related branches, and they are related branches. Perhaps if there's more than one branch, if one of them is called bugNNNNN, then the tools could infer that is the immediate bugfix, and the others are merely related.

Can I add "add-xsd" and "java-api" back in as related branches?

Revision history for this message
Thierry Carrez (ttx) wrote :

After reading your explanation, I agree that add-xsd is definitely part of the bugfix, so I added it back (and removed the requirement for FFe on that branch). I am a bit more unsure about java-bindings, which IIUC is not part of the bugfix, but rather one way to test the XML namespace (among others)... You can still mention the bug in the description (LP will autolink it so people are still able to follow the link).

Revision history for this message
Thierry Carrez (ttx) wrote :

@Justin: Where are we on add-xsd ? Is it still desirable ?

Revision history for this message
Brian Waldon (bcwaldon) wrote :

xmlns is now returned on all entities

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → diablo-3
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-3 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.