Little glitches in code

Bug #739766 reported by Thibault Févry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pastebinit
Fix Released
Medium
Unassigned

Bug Description

I didn't wanted to make a bug for each little glitch cause else I would open many bugs for nothing. So here are some tips :

1. Make test.sh executable, it helps when using ls (If you have color support) to know which files are executables, and it also allows you to do just "./test.sh"
2. Rename pb.daviey.com to pb.daviey.com.conf so that it follows the convention other files use.

Now in pastebinit itself
1. The sys.exit() instruction line 346 is useless, the code will never reach it (There's a raise just before...)
2. Line 165 and following: You may want to use triple-quotes instead of print, print... + "Reads on stdin for input or takes a filename as first parameter" is not translatable (and it's one of the most important strings).

Revision history for this message
Stéphane Graber (stgraber) wrote :

Thanks for the bug report. Next release of pastebinit will be a major rewrite but I'll check that these are fixed.

Changed in pastebinit:
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Rolf Leggewie (r0lf) wrote :

pb.daviey.com is dealt with in bug 809371

Revision history for this message
Stéphane Graber (stgraber) wrote :

Ok, apparently we'll have yet another release of the old code.

I fixed all the issues you mentioned except for the multiple calls to print to avoid breaking all the translations at this point, I simply made the extra string call _() too.

Thanks

Changed in pastebinit:
status: In Progress → Fix Committed
Changed in pastebinit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.