no pixmap / icon

Bug #739760 reported by Fabi
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
hedgewars (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: hedgewars

there isnt a application icon in the package for hedgewars 0.9.15. so your menu starter has no icon

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: hedgewars 0.9.15-1
ProcVersionSignature: Ubuntu 2.6.38-7.36-generic 2.6.38
Uname: Linux 2.6.38-7-generic i686
Architecture: i386
Date: Mon Mar 21 22:44:15 2011
InstallationMedia: Kubuntu 10.10 "Maverick Meerkat" - Release i386 (20101007)
ProcEnviron:
 LANGUAGE=de_DE
 LANG=de_DE.UTF-8
 LC_MESSAGES=de_DE.UTF-8
 SHELL=/bin/bash
SourcePackage: hedgewars
UpgradeStatus: Upgraded to natty on 2011-03-11 (10 days ago)

Related branches

Revision history for this message
Fabi (fabsi-deactivatedaccount) wrote :
Revision history for this message
Dylan McCall (dylanmccall) wrote :

I can confirm this, too. The .desktop file has an icon field, set to hedgewars.png, but neither hedgewars nor hedgewars-data are installing a file with this name.

Changed in hedgewars (Ubuntu):
status: New → Confirmed
Revision history for this message
Dylan McCall (dylanmccall) wrote :

Okay, I started taking a look at this. Looks like Hedgewars has two icons in its source package under the misc directory, neither of which are picked up by the packaging.

The first is hedgewars.png, which is a rather unfortunate 32px image.
The other is Icon.icns, which is MacOS's icon format. icns2png with that gives me a bunch of PNGs going up to 512x512px. It would be nice to use those :)

I'm attaching a patch that adds icnsutils as a build dependency. It's a little weird: this adds a build step to extract the icons and install them to the right place without touching the upstream source. I hope I'm doing this the right way; I am a total packaging klutz. It does work on my end, so that's a good sign!
Subscribing the sponsors team…

Revision history for this message
Kees Cook (kees) wrote :

Thanks for this patch! It looks like some cmake cruft got into it by accident, so I've cleaned that up. I also reworked the use of icns2png so that no files were left in the source tree (i.e. no need to add anything to the "clean" target too), moved the icons to the -data package (since they are arch-indep) and updated your changelog slightly to include the files that were changed. I've also forwarded this patch to Debian, since they are the upstream maintainer for this package.

Thanks again!

Changed in hedgewars (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hedgewars - 0.9.15-1ubuntu1

---------------
hedgewars (0.9.15-1ubuntu1) natty; urgency=low

  * debian/{control,rules,hedgewars-data.install}: extract and install high
    quality icons for .desktop file (LP: #739760).
 -- Dylan McCall <email address hidden> Wed, 06 Apr 2011 18:11:16 -0700

Changed in hedgewars (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Dylan McCall (dylanmccall) wrote :

Wonderful. Thank you, Kees!
Do you think Software Centre will pick those icons up when they're in -data? If not, I'm tempted to run over to app-install-data and beg them to do something for us :)

Revision history for this message
Derek (bugs-m8y) wrote :

Hey. Just FYI...
Not sure about image packaging but I noticed in comment #3 that you are unpacking the mac icon.
If at any point:
http://hedgewars.googlecode.com/hg/misc/hedgewars.png

was 32px, that was an accident.
It is back to 512px now.

Another image you could use is:
http://hedgewars.googlecode.com/hg/share/hedgewars/Data/Graphics/hedgehog.svg

I'm not totally sure why that isn't under /misc/ p'raps we should move it...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.