[armhf] libffi variadic support

Bug #739305 reported by Dr. David Alan Gilbert
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro GCC
Won't Fix
Undecided
Unassigned
gcc-4.6 (Ubuntu)
Won't Fix
Medium
Unassigned
Oneiric
Won't Fix
Medium
Unassigned
libffi (Ubuntu)
Fix Released
Medium
Unassigned
Oneiric
Fix Released
Medium
Unassigned

Bug Description

Libffi (3.0.9) does not explicitly support calls to variadic functions - however for most architectures they tend to work.
For armhf this is not the case - variadic calls drop back to the armel ABI; to support this I added a new API to libffi to explicitly support calling variadic functions.

The attached patch was accepted upstream and will land sometime after 3.0.10; we might want to merge it in sooner if we need armhf support sooner.

Note that programs that use libffi will also need changing for their variadic calls to work - but nothing that already works should break.

Dave

Tags: armhf
Revision history for this message
Dr. David Alan Gilbert (davidgil-uk) wrote :
tags: added: armhf
Steve Langasek (vorlon)
Changed in libffi (Ubuntu Oneiric):
status: New → Triaged
Revision history for this message
Steve Langasek (vorlon) wrote :

Matthias, can this patch be included in libffi now that oneiric is open? It's fairly important to have in before we begin armhf bootstrapping.

Changed in libffi (Ubuntu Oneiric):
assignee: nobody → Matthias Klose (doko)
importance: Undecided → Medium
milestone: none → oneiric-alpha-1
Revision history for this message
Matthias Klose (doko) wrote :

libffi 3.0.10 rc8 is in oneiric

which packages need to be fixed?

Changed in libffi (Ubuntu Oneiric):
status: Triaged → Fix Released
assignee: Matthias Klose (doko) → nobody
Revision history for this message
Dr. David Alan Gilbert (davidgil-uk) wrote :

libffi with the patch in comment #1

Dave

Steve Langasek (vorlon)
Changed in libffi (Ubuntu Oneiric):
status: Fix Released → Triaged
Revision history for this message
Dr. David Alan Gilbert (davidgil-uk) wrote :

Note that this patch should not break any existing package; it provides an extra API that some (currently broken on armhf and some other platforms) packages should start to use. Getting the patch in provides the API and gives us the opportunity to get the other packages fixed during the O cycle.

Dave

Revision history for this message
Matthias Klose (doko) wrote :

needs a backport for gcc-4.6/gcj-4.6

Changed in gcc-4.6 (Ubuntu Oneiric):
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libffi - 3.0.10~rc8-2

---------------
libffi (3.0.10~rc8-2) experimental; urgency=low

  * Add variadic support for armhf (David Gilbert). LP: #739305.
 -- Matthias Klose <email address hidden> Wed, 25 May 2011 09:20:53 +0000

Changed in libffi (Ubuntu Oneiric):
status: Triaged → Fix Released
Revision history for this message
Matthias Klose (doko) wrote :

won't fix in gcc-4.6

Changed in gcc-4.6 (Ubuntu):
status: Confirmed → Won't Fix
Changed in gcc-4.6 (Ubuntu Oneiric):
status: Confirmed → Won't Fix
Revision history for this message
Michael Hope (michaelh1) wrote :

Nothing to do in Linaro GCC. Note that the libffi included with GCC is 3.0.9.

Changed in gcc-linaro:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.